Bug 1989772: Rebase to k8s 1.22.0-rc.0 #195
Conversation
jkhelil
force-pushed
the
rebase_kube_0.22
branch
from
3e1bd3a
to
ad007f2
Compare
|
/retitle Bug 1986003: Rebase to k8s 1.22.0-rc.0 |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
bugzilla/severity-high
|
@jkhelil: This pull request references Bugzilla bug 1986003, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@jkhelil We do two commits for a vendor bump We also usually have the commit message for |
jkhelil
force-pushed
the
rebase_kube_0.22
branch
from
ad007f2
to
277dedd
Compare
done |
|
/retest |
|
/retitle Bug 1989772: Rebase to k8s 1.22.0-rc.0 |
openshift-ci
bot
changed the title
|
@jkhelil: This pull request references Bugzilla bug 1989772, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
/approve
Nit on the interface, otherwise I think this looks good.
The library-go bump includes the fix for BZ 1989772. We use the functions in library-go to set up the configuration for leader election. The update includes the new defaults that will make the controller tolerate apiserver downtime better.
| ) | ||
|
|
||
| // AuthenticatorMetrics specifies a set of methods that are used to register various metrics | ||
| type AuthenticatorMetrics struct { |
There was a problem hiding this comment.
Do we need to create an interface here? Can't we just add a godoc that this implements the webhooktoken.AuthenticatorMetrics interface
There was a problem hiding this comment.
nm - this is a struct, not an interface.
openshift-ci
bot
added
the
approved
|
May close this in favor of #196 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jkhelil: All pull requests linked via external trackers have merged: Bugzilla bug 1989772 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.