add resourcelock, leaderelection for cluster-policy-controller #28
Conversation
|
@sallyom: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| OnStartedLeading: originControllerManager, | ||
| OnStoppedLeading: func() { | ||
| klog.Fatalf("leaderelection lost") | ||
| components := []string{"openshift-controller-manager", "cluster-policy-controller"} |
There was a problem hiding this comment.
no. Only do a second leader election on the SCC namespace controller in particular, not all of it.
There was a problem hiding this comment.
I've updated, i'm new to this code, hopefully it's close, with cluster-admin rbac (will figure that out next) i get the leader lock cm in cluster-kube-controller-manager-ns.
sallyom
force-pushed
the
release-4.2
branch
from
cd240eb
to
c185ed4
Compare
|
@sallyom: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sallyom: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
open against master first please |
|
closing in favor of #33 opened against master branch |
Add Build CRD to Manifests
I've added a leader lock in the NamespaceSCCAllocationController for upgrades 4.2->4.3
to avoid conflicts with cluster-policy-controller container running in kube-controller-manager static pod
@deads2k
@stlaz