WRKLDS-1016: bump k8s to 1.29.1 #283
Conversation
| @@ -47,7 +48,7 @@ func RunControllerServer(servingInfo configv1.HTTPServingInfo, kubeExternal clie | |||
| return err | |||
| } | |||
| sarClient := kubeExternal.AuthorizationV1() | |||
| remoteAuthz, err := authzwebhook.NewFromInterface(sarClient, 5*time.Minute, 5*time.Minute, *authzwebhook.DefaultRetryBackoff(), authzwebhook.AuthorizerMetrics{ | |||
| remoteAuthz, err := authzwebhook.NewFromInterface(sarClient, 5*time.Minute, 5*time.Minute, *authzwebhook.DefaultRetryBackoff(), authorizer.DecisionNoOpinion, authzwebhook.AuthorizerMetrics{ | |||
There was a problem hiding this comment.
using the original default behaviour kubernetes/kubernetes@2e2f51a#diff-8b41b5e2c7d3bb27fa452e58ab0a4120b02d3a7a16d8961954f5c3c270ab8935L125
| @@ -114,28 +113,29 @@ func setupDockerSocket(pod *corev1.Pod) { | |||
| // mountConfigMapVolume is a helper method responsible for actual mounting configMap | |||
| // volumes into a pod. | |||
| func mountConfigMapVolume(pod *corev1.Pod, container *corev1.Container, configMapName, mountPath, volumeSuffix string, volumeSource *corev1.VolumeSource) { | |||
| mountVolume(pod, container, configMapName, mountPath, volumeSuffix, policy.ConfigMap, volumeSource) | |||
| mountVolume(pod, container, configMapName, mountPath, volumeSuffix, "configMap", volumeSource) | |||
There was a problem hiding this comment.
removed in kubernetes/kubernetes#119806
|
/retest |
|
@atiratree: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci-robot
added
the
jira/valid-reference
|
@atiratree: This pull request references WRKLDS-1016 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, ingvagabund, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 3369227
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-openshift-controller-manager-container-v4.16.0-202402070113.p0.g3369227.assembly.stream.el9 for distgit ose-openshift-controller-manager. |
No description provided.