Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-1016: bump k8s to 1.29.1 #283

Merged
merged 6 commits into from
Feb 6, 2024
Merged

WRKLDS-1016: bump k8s to 1.29.1 #283

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edcb985
bump go to 1.21
atiratree Jan 25, 2024
e59775f
bump k8s to 1.29.1
atiratree Jan 25, 2024
e17d55d
go mod vendor
atiratree Jan 25, 2024
1082f24
react to upstream removal of FSType
atiratree Jan 25, 2024
9de523c
react to naming changes in openshift/api
atiratree Jan 25, 2024
50ce7f7
react to upstream changes in authorizer/webhook
atiratree Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cmd/controller/standalone_apiserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

"k8s.io/apimachinery/pkg/runtime/serializer"
utilwait "k8s.io/apimachinery/pkg/util/wait"
"k8s.io/apiserver/pkg/authorization/authorizer"
apifilters "k8s.io/apiserver/pkg/endpoints/filters"
apiserver "k8s.io/apiserver/pkg/server"
apiserverfilters "k8s.io/apiserver/pkg/server/filters"
Expand Down Expand Up @@ -47,7 +48,7 @@ func RunControllerServer(servingInfo configv1.HTTPServingInfo, kubeExternal clie
return err
}
sarClient := kubeExternal.AuthorizationV1()
remoteAuthz, err := authzwebhook.NewFromInterface(sarClient, 5*time.Minute, 5*time.Minute, *authzwebhook.DefaultRetryBackoff(), authzwebhook.AuthorizerMetrics{
remoteAuthz, err := authzwebhook.NewFromInterface(sarClient, 5*time.Minute, 5*time.Minute, *authzwebhook.DefaultRetryBackoff(), authorizer.DecisionNoOpinion, authzwebhook.AuthorizerMetrics{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the original default behaviour kubernetes/kubernetes@2e2f51a#diff-8b41b5e2c7d3bb27fa452e58ab0a4120b02d3a7a16d8961954f5c3c270ab8935L125

RecordRequestTotal: noopMetrics{}.RequestTotal,
RecordRequestLatency: noopMetrics{}.RequestLatency,
})
Expand Down