New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVEXP-489: Rebase k8s 117 #51
DEVEXP-489: Rebase k8s 117 #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
In general looks good - would like review from apiserver/auth team on some of these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As a follow-up we may want to leverage the new release tags for go.mod (v0.17.0
for k8s.io libs)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit |
/retest Please review the full test history for this PR and help us cut down flakes. |
Use DefaultProxy for Build Git Proxy
/assign @adambkaplan
@openshift/openshift-team-developer-experience fyi