Bug 1809699: Restore openshift-controller-manager metrics #69
Conversation
adambkaplan
commented
Mar 3, 2020
•
adambkaplan
commented
- Fix DeploymentConfig, ImageStream, and TemplateInstance metrics
- Fix version info metric
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
* Fix DeploymentConfig, ImageStream, and TemplateInstance metrics * Fix version info metric
adambkaplan
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@adambkaplan: This pull request references Bugzilla bug 1809699, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@adambkaplan: This pull request references Bugzilla bug 1809699, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @gabemontero |
|
/cherrypick release-4.4 |
|
@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 This was introduced with the 1.16 rebase. |
|
@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
/lgtm
so this is basically copying what you did for builds last fall @adambkaplan with 0f4a457#diff-98b652336af5502707853be5b5250d62
right?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero correct. I have a sneaking suspicion there are several other metrics missing in 4.3 |
|
@adambkaplan: All pull requests linked via external trackers have merged. Bugzilla bug 1809699 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: new pull request created: #70 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: new pull request created: #71 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
