Bug 1815816: more timing windows on build/pod owner ref correlation (allow GC to c… #96
Conversation
…lean up old pods)
openshift-ci-robot
added
bugzilla/severity-medium
|
@gabemontero: This pull request references Bugzilla bug 1815816, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@gabemontero: All pull requests linked via external trackers have merged: openshift/openshift-controller-manager#94, openshift/openshift-controller-manager#96. Bugzilla bug 1815816 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -1087,6 +1092,21 @@ func (bc *BuildController) resolveImageReferences(build *buildv1.Build, update * | |||
| return nil | |||
| } | |||
|
|
|||
| func retryOnOwnerRef(build *buildv1.Build, pod *corev1.Pod) error { | |||
| if len(pod.OwnerReferences) > 0 { | |||
There was a problem hiding this comment.
A general rule is to return early, the code will read better if this looks like:
if len(pod.OwnerReferences) == 0 {
return nil
}
// ... rest of the code
Bug 1704874: Create ConfigMap for Registry CA
…lean up old pods)
QE testing and subsequent retries by me found a timing window we missed with #94
/assign @adambkaplan
@bparees fyi