Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docker registry access) add a first step to create a regular user, with example #1050

Merged
merged 1 commit into from Nov 14, 2015
Merged

(docker registry access) add a first step to create a regular user, with example #1050

merged 1 commit into from Nov 14, 2015

Conversation

tnguyen-rh
Copy link

adellape
adellape reviewed Oct 8, 2015
View reviewed changes
install_config/install/docker_registry.adoc
@@ -239,7 +239,17 @@ this repository via an image.
To access the registry directly, such as to perform `docker push` or `docker pull` operations, you
must first log in to the registry using an access token.

. Ensure you are logged in to OpenShift as a link:../../architecture/core_concepts/projects_and_users.html#users[regular user]:
. Create a link:../../architecture/core_concepts/projects_and_users.html#users[regular user], for example, with `HTPASSWD` authentication:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they may have already created or have access to a regular user, or chosen a different identity provider, suggest something like:

If a link:../../architecture/core_concepts/projects_and_users.html#users[regular user] does not already exist, create one according to your chosen link:../../admin_guide/configuring_authentication.html[identity provider]. For example, if you are using htpasswd authentication:

@tnguyen-rh
Copy link
Author

@adellape Thanks. I've made the changes you suggested.
@rjhowe PTAL

@tnguyen-rh
Copy link
Author

@rjhowe BTW, the pretty render is at:

https://github.com/tnguyen-rh/openshift-docs/blob/bz1248706/install_config/install/docker_registry.adoc#access

@tnguyen-rh
Copy link
Author

@rjhowe @adellape
Summary of the IRC discussion:

  • current doc is incomplete (does not mention granting proper privs)
  • maybe 3.1 will be fully automagic, but that's 3.1 -- in the meantime...
  • new proposal:
    1. describe in overview the necessity of a "regular user" w/ proper privs
    2. mention in topic "Projects and Users", section "Users", table entry "Regular users" that such users are necessary for docker registry access

@adellape adellape changed the title (docker registry access) add a first step to create a regular user, with example [WIP] (docker registry access) add a first step to create a regular user, with example Oct 14, 2015
@adellape
Copy link
Contributor

@tnguyen-rh Based on latest comment, my understanding is you wanted to continue working on this, right? If I've misunderstand, you can undo my [WIP]-titling.

@tnguyen-rh
Copy link
Author

@adellape
Yes, this is indeed WIP.
@rjhowe
Any thoughts on the proposed rework?

@rjhowe
Copy link

rjhowe commented Oct 15, 2015

@tnguyen-rh When you say proposed rework. Are we talking about having a separate section that goes into detail regarding the registry?
My thoughts:
With the install section have basic setup steps for the registry. Then link to a section in the admin guide that goes into detail working with the registry, securing it, configuring it, how to enable access to it for the devs, and so on.

@tnguyen-rh
Copy link
Author

@rjhowe
The rework concerns the "regular user" requirement only. I've installed efe35f5 (after rebase).
Preview: https://github.com/tnguyen-rh/openshift-docs/blob/bz1248706/install_config/install/docker_registry.adoc

@rjhowe
Copy link

rjhowe commented Oct 30, 2015

Looks good.

@tnguyen-rh
Copy link
Author

@adellape Squashed, rebased. Ready to merge (pending travis).

@tnguyen-rh tnguyen-rh changed the title [WIP] (docker registry access) add a first step to create a regular user, with example (docker registry access) add a first step to create a regular user, with example Nov 12, 2015
adellape
adellape reviewed Nov 12, 2015
View reviewed changes
install_config/install/docker_registry.adoc
@@ -20,6 +20,18 @@ link:../../architecture/infrastructure_components/image_registry.html#integrated
Docker registry] that can be deployed in your OpenShift environment to locally
manage images.

To make full use of the registry, you must create a link:../../architecture/core_concepts/projects_and_users.html#users[regular user] with the `system:registry` role, if one does not already exist, using your preferred link:../../admin_guide/configuring_authentication.html[identity provider].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some inconsistent markup between roles and users mentioned in the topic. E.g., compare system:registry, system:image-builder, system:admin, etc. They should probably be the same; the precedent was using plain bold as "system items" (fuzzy, I know).

@adellape
Copy link
Contributor

@tnguyen-rh Some comments inline. Looking good. BTW, there are some new lines that have not been wrapped at 80, as well.

@adellape adellape added this to the OSE 3.1 milestone Nov 12, 2015
@tnguyen-rh
Copy link
Author

@adellape Thanks for the review. I've updated accordingly (plus squash and rebase).

@tnguyen-rh tnguyen-rh self-assigned this Nov 14, 2015
tnguyen-rh added a commit that referenced this pull request Nov 14, 2015
@tnguyen-rh
Merge pull request #1050 from tnguyen-rh/bz1248706
7ea4de4 
(docker registry access) add a first step to create a regular user, with example
@tnguyen-rh tnguyen-rh merged commit 7ea4de4 into openshift:master Nov 14, 2015
@tnguyen-rh tnguyen-rh deleted the bz1248706 branch November 14, 2015 12:21
@tnguyen-rh tnguyen-rh mentioned this pull request Jan 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tnguyen-rh tnguyen-rh

Labels
None yet
Projects
None yet
Milestone
OSE 3.1 GA
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tnguyen-rh @adellape @rjhowe