Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document imageimport pem file argument #10740

Merged
merged 1 commit into from Jul 26, 2018
Merged

document imageimport pem file argument #10740

merged 1 commit into from Jul 26, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 10, 2018

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2018
@bparees
Copy link
Contributor Author

bparees commented Jul 10, 2018

@bmcelvee ptal. 3.11 and above only.

@bmcelvee
Copy link
Contributor

Thanks, @bparees! LGTM

@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2018

@bmcelvee this one might have fallen off your radar

@bmcelvee
Copy link
Contributor

Thanks, @bparees! I'm sorry about that, I'll get it merged today.

@bmcelvee bmcelvee added this to the Future Release milestone Jul 26, 2018
@bmcelvee
Copy link
Contributor

Minor change. Does not require QE.

@bmcelvee bmcelvee merged commit 7a5f25c into openshift:master Jul 26, 2018
@xingxingxia
Copy link
Contributor

Now I read this but seems didn't see this doc in 3.11 doc ? Anything wrong? (I come here pointed to by 1592936#c29)

@bparees
Copy link
Contributor Author

bparees commented Nov 13, 2018

@xingxingxia good question.. @bmcelvee ?

it is in the origin docs:
https://docs.okd.io/latest/install_config/master_node_configuration.html#master-config-image-policy-config

Note that we've actually addressed this a different way anyway, the api server is going to start mounting the /etc/pki from the host node, so you should not need to use this setting.

@bmcelvee
Copy link
Contributor

Looks like this one [somehow] didn't get pulled into the 3.11 branch when it was created. I'm sorry about that.

@bparees Even though it's addressed in a different way, I can still cherry-pick the parameter + description into 3.11. Is that okay with you?

@bparees
Copy link
Contributor Author

bparees commented Nov 13, 2018

@bmcelvee that's fine.

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #12850

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bmcelvee
Copy link
Contributor

Thanks! All set.

@bparees bparees deleted the pem branch February 27, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.11 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants