Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP8 Documentation and Release Notes Updates #13668

Merged
merged 1 commit into from Feb 27, 2019

Conversation

geekspertise
Copy link
Contributor

Here are the updated docs for Service Mesh TP8 including the 3scale Istio Adapter 0.3 documentation update and some general clean up. Can @knrc @tvieira @JStickler @brian-avery and @vramosp provide feedback?

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2019
@knrc
Copy link

knrc commented Feb 20, 2019

@geekspertise These changes look good to me, is there a preview version?

@geekspertise
Copy link
Contributor Author

@geekspertise These changes look good to me, is there a preview version?

Unfortunately the OpenShift Preview Bot doesn't seem like it was ever fixed to work with my account.

@vramosp
Copy link

vramosp commented Feb 20, 2019

@geekspertise LGTM

@tvieira
Copy link

tvieira commented Feb 20, 2019

LGTM

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not talking about a mobile app, all references in the 3Scale topic to "app" should be changed to "application". Other than that, looks pretty good to me.

@geekspertise
Copy link
Contributor Author

PR Update w/ fresh content:
@knrc and I added a new topic comparing the upstream Istio community install versus Service Mesh. I also addressed the previous comments and a few other issues. @knrc and @JStickler can you provide feedback on the new content? And @vramosp please take a look at the 3scale Adapter docs as some language changes were made so it fits with the Service Mesh docs.

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one update, other than that looks good to me.

@geekspertise
Copy link
Contributor Author

@kalexand-rh and @vikram-redhat I got the blessing from @knrc to merge this content.

@vikram-redhat
Copy link
Contributor

@geekspertise - I can't recall if we are going through the peer review process for ServiceMesh docs. If yes, can you put this on peer review (if it hasn't already been peer reviewed)?

@geekspertise
Copy link
Contributor Author

geekspertise commented Feb 26, 2019 via email

@geekspertise
Copy link
Contributor Author

@vikram-redhat When is this PR going to be merged? It was peer reviewed before I requested the merge.

@kalexand-rh
Copy link
Contributor

I see where @JStickler did the peer review, so I'm going to merge.

@kalexand-rh kalexand-rh merged commit 4d4bfa9 into openshift:master Feb 27, 2019
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #13854

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.11 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants