New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP8 Documentation and Release Notes Updates #13668
Conversation
@geekspertise These changes look good to me, is there a preview version? |
Unfortunately the OpenShift Preview Bot doesn't seem like it was ever fixed to work with my account. |
@geekspertise LGTM |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're not talking about a mobile app, all references in the 3Scale topic to "app" should be changed to "application". Other than that, looks pretty good to me.
a003b09
to
9392092
Compare
PR Update w/ fresh content: |
f3f5356
to
64c5578
Compare
64c5578
to
6e8b1b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one update, other than that looks good to me.
6e8b1b3
to
d02b937
Compare
@kalexand-rh and @vikram-redhat I got the blessing from @knrc to merge this content. |
@geekspertise - I can't recall if we are going through the peer review process for ServiceMesh docs. If yes, can you put this on peer review (if it hasn't already been peer reviewed)? |
It has already been peer reviewed.
…On Mon, Feb 25, 2019, 5:18 PM Vikram Goyal ***@***.***> wrote:
@geekspertise <https://github.com/geekspertise> - I can't recall if we
are going through the peer review process for ServiceMesh docs. If yes, can
you put this on peer review (if it hasn't already been peer reviewed)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13668 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Anhd287UoDlz5aNlmquTpbaNVliDkMF1ks5vRGEpgaJpZM4bDqQ2>
.
|
@vikram-redhat When is this PR going to be merged? It was peer reviewed before I requested the merge. |
I see where @JStickler did the peer review, so I'm going to merge. |
/cherrypick enterprise-3.11 |
@kalexand-rh: new pull request created: #13854 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Here are the updated docs for Service Mesh TP8 including the 3scale Istio Adapter 0.3 documentation update and some general clean up. Can @knrc @tvieira @JStickler @brian-avery and @vramosp provide feedback?