New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP11 Documentation and Release Notes Updates #15065
Conversation
lgtm, other than a couple of small issues. |
Tagging @philipgough, @seanhuck, @vramosp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found one issue with the URL for the on-premises installation.
@dmitri-d All of the documentation still resides in the 3.11 branch of the OpenShift Docs because OpenShift 4 has not been released and those docs are still password protected. |
/lgtm |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, but otherwise LGTM.
fbc5171
to
f03090c
Compare
@vikram-redhat and @kalexand-rh Can you review/prep this PR for our TP11 release on Monday? This PR cannot be merged until the product is released Monday. @JStickler has already performed a content peer review. |
@geekspertise Tag any @openshift/team-documentation team member to merge this when the TP11 has released. If it doesn't release till 10 PM today (3/Jun), then it will have to wait till after OCP 4.1 releases. |
@geekspertise, those were the only two issues that stood out after a quick scan. Let me know if you're ready to merge. |
@kalexand-rh I made the changes you pointed out and forced an update to the PR moments ago. At this point, we're good to merge for TP11. |
@geekspertise, thanks! I'll merge when the build passes, then. These changes are just for the 3.11 collection, right? |
@kalexand-rh Yes we're still publishing docs solely in 3.11 for now. |
/cherrypick enterprise-3.11 |
@kalexand-rh: new pull request created: #15124 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Here is the first draft of documentation updates for TP11, but it is still a work in progress.
Can @knrc @tvieira @bdecoste @brian-avery @rcernich and @JStickler please review this PR and provide feedback?
Can @dfennessy review the 3scale documentation and tag any additional reviewers if necessary?