Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP11 Documentation and Release Notes Updates #15065

Merged
merged 1 commit into from Jun 3, 2019

Conversation

geekspertise
Copy link
Contributor

Here is the first draft of documentation updates for TP11, but it is still a work in progress.

Can @knrc @tvieira @bdecoste @brian-avery @rcernich and @JStickler please review this PR and provide feedback?

Can @dfennessy review the 3scale documentation and tag any additional reviewers if necessary?

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 29, 2019
@dmitri-d
Copy link

lgtm, other than a couple of small issues.
I noticed all links have "3.11" in them, I thought that we supported Service Mesh on OCP 4.x only?

@dfennessy
Copy link
Contributor

Here is the first draft of documentation updates for TP11, but it is still a work in progress.

Can @knrc @tvieira @bdecoste @brian-avery @rcernich and @JStickler please review this PR and provide feedback?

Can @dfennessy review the 3scale documentation and tag any additional reviewers if necessary?

Tagging @philipgough, @seanhuck, @vramosp

Copy link
Contributor

@dfennessy dfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one issue with the URL for the on-premises installation.

@geekspertise
Copy link
Contributor Author

lgtm, other than a couple of small issues.
I noticed all links have "3.11" in them, I thought that we supported Service Mesh on OCP 4.x only?

@dmitri-d All of the documentation still resides in the 3.11 branch of the OpenShift Docs because OpenShift 4 has not been released and those docs are still password protected.

@tvieira
Copy link

tvieira commented May 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, but otherwise LGTM.

servicemesh-install/topics/install-multi-tenant.adoc Outdated Show resolved Hide resolved
servicemesh-install/topics/install-multi-tenant.adoc Outdated Show resolved Hide resolved
servicemesh-install/topics/install-multi-tenant.adoc Outdated Show resolved Hide resolved
servicemesh-install/topics/install-multi-tenant.adoc Outdated Show resolved Hide resolved
@geekspertise geekspertise force-pushed the servicemesh branch 4 times, most recently from fbc5171 to f03090c Compare May 31, 2019 12:20
@geekspertise
Copy link
Contributor Author

@vikram-redhat and @kalexand-rh Can you review/prep this PR for our TP11 release on Monday? This PR cannot be merged until the product is released Monday.

@JStickler has already performed a content peer review.

@vikram-redhat
Copy link
Contributor

@geekspertise Tag any @openshift/team-documentation team member to merge this when the TP11 has released. If it doesn't release till 10 PM today (3/Jun), then it will have to wait till after OCP 4.1 releases.

@kalexand-rh
Copy link
Contributor

@geekspertise, those were the only two issues that stood out after a quick scan. Let me know if you're ready to merge.

@geekspertise
Copy link
Contributor Author

@kalexand-rh I made the changes you pointed out and forced an update to the PR moments ago. At this point, we're good to merge for TP11.

@kalexand-rh
Copy link
Contributor

@geekspertise, thanks! I'll merge when the build passes, then.

These changes are just for the 3.11 collection, right?

@geekspertise
Copy link
Contributor Author

@kalexand-rh Yes we're still publishing docs solely in 3.11 for now.

@kalexand-rh kalexand-rh merged commit 3924fd4 into openshift:master Jun 3, 2019
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #15124

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.11 size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet