Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PROD-615-proxy-enablement #16392

Closed

Conversation

bmcelvee
Copy link
Contributor

@bmcelvee bmcelvee added this to the Future Release milestone Aug 26, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2019
@openshift-docs-preview-bot

The preview will be available shortly at:

name: ""
status:
----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmcelvee currently enable-cluster-wide-proxy.adoc provides guidance on how to modify a cluster to enable proxy, but not how to create a cluster with proxy enabled. Do you mind using some of the references I provided here to expand enable-cluster-wide-proxy.adoc or create a new doc that provides the steps for creating a new cluster with proxy enabled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need a separate assembly to cover the installation with proxy piece. @bmcelvee, I might have time to make that next week.

@danehans
Copy link
Contributor

I think it would be beneficial to add a proxy section under networking that leverages the details of this doc. I think it's important for people to understand what the controllers do, which operator runs the controller, how the CA injection stuff works, etc..

selfLink: /apis/config.openshift.io/v1/proxies/cluster
uid: <user ID string>
spec:
httpProxy: http://admin:admin@35.196.128.173:3128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change so the doc is not referencing our test proxy.

uid: <user ID string>
spec:
httpProxy: http://admin:admin@35.196.128.173:3128
httpsProxy: https://admin:admin@35.231.5.161:3128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change so the doc is not referencing our test proxy.

trustedCA:
name: user-ca-bundle
status:
httpProxy: http://admin:admin@35.196.128.173:3128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change so the doc is not referencing our test proxy.

name: user-ca-bundle
status:
httpProxy: http://admin:admin@35.196.128.173:3128
httpsProxy: https://admin:admin@35.231.5.161:3128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change so the doc is not referencing our test proxy.

@danehans
Copy link
Contributor

danehans commented Sep 3, 2019

@bmcelvee due to https://bugzilla.redhat.com/show_bug.cgi?id=1743174, a docs note is needed stating: The install config machineCIDR directive is used to bypass proxy for internal cluster connections. For deployments such as bare-metal that do not use machineCIDR, one of the following steps should be completed for proxy to function properly:

  1. Cluster node IP's should be assigned from machineCIDR.
  2. machineCIDR should be updated to reflect the CIDR being used for cluster nodes
  3. Add cluster node IPs or CIDR to noProxy of proxy "cluster".

This might be a good place for the docs note. However, the example install config provided does not include a machineCIDR. Here is my install-config:

$ cat latest-proxy/install-config.yaml 
apiVersion: v1
baseDomain: devcluster.openshift.com
compute:
- hyperthreading: Enabled
  name: worker
  platform: {}
  replicas: 3
controlPlane:
  hyperthreading: Enabled
  name: master
  platform: {}
  replicas: 3
metadata:
  creationTimestamp: null
  name: latest-proxy
networking:
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  machineCIDR: 10.0.0.0/16
  networkType: OpenShiftSDN
  serviceNetwork:
  - 172.30.0.0/16
platform:
  aws:
    region: us-west-2
pullSecret: <PULL_SECRET>
sshKey: |
  ssh-rsa <SSH_KEY>

@bergerhoffer
Copy link
Contributor

Closing this PR in favor of #16562.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants