Bug 1741922, fixed initrd argument #17561
Conversation
openshift-ci-robot
added
the
size/XS
|
The preview will be available shortly at: |
| @@ -63,7 +63,7 @@ TIMEOUT 20 | |||
| PROMPT 0 | |||
| LABEL pxeboot | |||
| KERNEL http://<HTTP_server>/rhcos-<version>-<architecture>-installer-kernel <1> | |||
| APPEND ip=dhcp rd.neednet=1 initrd=http://<HTTP_server>/rhcos-<version>-<architecture>-installer-initramfs.img console=tty0 console=ttyS0 coreos.inst=yes coreos.inst.install_dev=sda coreos.inst.image_url=http://<HTTP_server>/rhcos-<version>-<architecture>-metal-bios.raw.gz coreos.inst.ignition_url=http://<HTTP_server>/bootstrap.ign <2> <3> | |||
| APPEND ip=dhcp rd.neednet=1 initrd=rhcos-<version>-<architecture>-installer-initramfs.img console=tty0 console=ttyS0 coreos.inst=yes coreos.inst.install_dev=sda coreos.inst.image_url=http://<HTTP_server>/rhcos-<version>-<architecture>-metal-bios.raw.gz coreos.inst.ignition_url=http://<HTTP_server>/bootstrap.ign <2> <3> | |||
There was a problem hiding this comment.
I think this change should be at line 81 instead, unless it applies to both iPXE and PXE.
@morenod, will you PTAL?
There was a problem hiding this comment.
both PXE and iPXE can use http locations for kerner, initrd and image files
There was a problem hiding this comment.
@morenod Thanks. I'm looking into your comment in the BZ.
There was a problem hiding this comment.
@rvanderp3 See the above comment. Per the BZ, could the problem be that http:\the-server:8080\rhcos-4.1.0-x86_64-installer-initramfs.img should be http:// instead of http:\?
There was a problem hiding this comment.
@morenod Please see https://bugzilla.redhat.com/show_bug.cgi?id=1741922#c6 and advise. Thank you!
|
@morenod could you help review this. |
|
lgtm |
ahardin-rh
added
the
peer-review-done
|
/cherrypick enterprise-4.2 |
|
@ahardin-rh: new pull request created: #18406 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.3 |
|
@ahardin-rh: new pull request created: #18407 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1741922
@kalexand-rh @jianlinliu Can you please review?