Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1786779: refer to filesystem storage classes, fix namespace #19354

Merged
merged 1 commit into from Jan 31, 2020

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Jan 28, 2020

Hi @s-urbaniak , do the changes in 4f4b86c and 3b19fa1 look good? And do we want to confirm them with the QE or are we certain? Thanks.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
Copy link

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@s-urbaniak
Copy link
Contributor

/rename Bug 1786779: refer to filesystem storage classes, fix namespace

@rh-max rh-max changed the title Monitoring post4.3 fixes Bug 1786779: refer to filesystem storage classes, fix namespace Jan 28, 2020
@openshift-ci-robot
Copy link

@rh-max: This pull request references Bugzilla bug 1786779, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1786779: refer to filesystem storage classes, fix namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 28, 2020
@rh-max rh-max force-pushed the monitoring-post4.3-fixes branch 3 times, most recently from 04080bc to 28ce41e Compare January 28, 2020 13:08
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@juzhao
Copy link

juzhao commented Jan 31, 2020

/lgtm

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 31, 2020
@bmcelvee
Copy link
Contributor

LGTM

@openshift-ci-robot
Copy link

@rh-max: All pull requests linked via external trackers have merged. Bugzilla bug 1786779 has been moved to the MODIFIED state.

In response to this:

Bug 1786779: refer to filesystem storage classes, fix namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #19425

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bmcelvee
Copy link
Contributor

bmcelvee commented Jan 31, 2020

/cherrypick enterprise-4.4

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #19426

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -50,7 +50,8 @@ data:
*prometheusK8s*:
*volumeClaimTemplate:
spec:
storageClassName: gluster-block
storageClassName: fast
volumeMode: filesystem
Copy link

@juzhao juzhao Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be
volumeMode: Filesystem
if we use filesystem, PVCs can not be created, we support "Block", "Filesystem", not "filesystem"
`$ oc -n openshift-monitoring describe sts alertmanager-main
Events:
Type Reason Age From Message


Warning FailedCreate 3m48s (x12 over 3m58s) statefulset-controller create Pod prometheus-k8s-0 in StatefulSet prometheus-k8s failed error: failed to create PVC prometheus-k8s-db-prometheus-k8s-0: PersistentVolumeClaim "prometheus-k8s-db-prometheus-k8s-0" is invalid: spec.volumeMode: Unsupported value: "filesystem": supported values: "Block", "Filesystem"`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juzhao, fixing in #19573.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.3 branch/enterprise-4.4 bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants