Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging upgrade #1965

Merged
merged 2 commits into from May 2, 2016
Merged

Logging upgrade #1965

merged 2 commits into from May 2, 2016

Conversation

adellape
Copy link
Contributor

Pulls in commit from #1933 and applies edits and moves section to the Manual Upgrades topic.

Pretty build:

http://file.rdu.redhat.com/~adellape/042816/logging-upgrade/install_config/upgrading/manual_upgrades.html#manual-upgrading-logging-components

@dgoodwin @sosiouxme PTAL?

@bfallonf Peer review since you've done logging stuff before?

If you have previously link:../../install_config/aggregate_logging.html[deployed
logging components] and want to upgrade your EFK stack with new images, you must
take the following steps to safely upgrade with minimal disruption to your log
data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Logging components" the correct way to call this stuff? Is "the EFK" stack the better term? Maybe it encompasses a few more things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might rename it "Upgrading the EFK Logging Stack" (looks like we use that phrasing in https://docs.openshift.org/latest/install_config/aggregate_logging.html#overview). I was wanting to get the word "logging" more obviously into the heading.

@bfallonf
Copy link

@adellape A few suggestions. Otherwise, looks good.

@adellape
Copy link
Contributor Author

@bfallonf Thanks, will work on that stuff.

@dgoodwin
Copy link

👍 from me.

@adellape
Copy link
Contributor Author

images, the steps must be performed manually as shown in
link:../../install_config/upgrading/manual_upgrades.html#manual-upgrading-efk-logging-stack[Manual
Upgrades].

Copy link
Contributor Author

@adellape adellape Apr 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgoodwin Added a pointer from the Automated Upgrades to the manual steps for now, which we can update if the playbooks are able to handle this in later releases.

logging-elasticsearch
logging-fluentd
logging-kibana
----
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgoodwin Added a list of what imagestreams to run the command on, can you ack? I see there's also the "logging-deployment" image out there on registry.access, but I don't think that it needs to get pulled here, right? I don't have an actual imagestream of that, plus it would just get pulled during initial logging deployments?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually write any of the docs from that other PR, they're just a direct copy paste from the upstream repo and the authors there, being moved to help close out a task we had to make sure this was covered. Hopefully @ewolinetz or @sosiouxme can help with any questions.

Upstream repo they came from was https://github.com/openshift/origin-aggregated-logging#upgrading-your-efk-stack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, there's a logging-deployment image but nothing creates an IS for it because it's invoked as a one-off pod from the deployer template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexd I would actually say "the list of ImageStreams are..." - the image names are something more involved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually say "the list of ImageStreams are..." - the image names are something more involved

@sosiouxme Righto, had been going back and forth on that.

Also sorry to "alexd" - you got hit by my IRC nick ;)

@sosiouxme
Copy link
Member

LGTM

@adellape
Copy link
Contributor Author

adellape commented May 2, 2016

$ oc scale dc/logging-es-<unique_name> --replicas=1
----
+
Tail the logs of the resulting pod to ensure that it was able to recover its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a novice user, tail is a new-to-me term. Should a command be added here to show what you mean, or do you think the target audience should already know what is meant here?

@ahardin-rh
Copy link
Contributor

@adellape Just one comment. Other than that, LGTM!

----
+
If that is successful, you can then do the same for the operations cluster, if
one was previously used.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh See above per your suggestion. Changed it from "tail" to "follow" and showed usage of a command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape Looks good!

@adellape adellape merged commit a8a83f6 into openshift:master May 2, 2016
@adellape
Copy link
Contributor Author

adellape commented May 2, 2016

[rev_history]
|link:../install_config/upgrading/manual_upgrades.html[Upgrading -> Manual Upgrades]
|Added the link:../install_config/upgrading/manual_upgrades.html#manual-upgrading-efk-logging-stack[Upgrading the EFK Logging Stack] section.
%

@adellape adellape modified the milestones: OSE 3.2, Staging, OSE 3.2 (Picked) May 9, 2016
@adellape adellape deleted the logging-upgrade branch May 16, 2016 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants