New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging upgrade #1965
Logging upgrade #1965
Conversation
If you have previously link:../../install_config/aggregate_logging.html[deployed | ||
logging components] and want to upgrade your EFK stack with new images, you must | ||
take the following steps to safely upgrade with minimal disruption to your log | ||
data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Logging components" the correct way to call this stuff? Is "the EFK" stack the better term? Maybe it encompasses a few more things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might rename it "Upgrading the EFK Logging Stack" (looks like we use that phrasing in https://docs.openshift.org/latest/install_config/aggregate_logging.html#overview). I was wanting to get the word "logging" more obviously into the heading.
@adellape A few suggestions. Otherwise, looks good. |
@bfallonf Thanks, will work on that stuff. |
👍 from me. |
797bb58
to
fbe44a2
Compare
fbe44a2
to
218a155
Compare
images, the steps must be performed manually as shown in | ||
link:../../install_config/upgrading/manual_upgrades.html#manual-upgrading-efk-logging-stack[Manual | ||
Upgrades]. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgoodwin Added a pointer from the Automated Upgrades to the manual steps for now, which we can update if the playbooks are able to handle this in later releases.
218a155
to
4ae4138
Compare
logging-elasticsearch | ||
logging-fluentd | ||
logging-kibana | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgoodwin Added a list of what imagestreams to run the command on, can you ack? I see there's also the "logging-deployment" image out there on registry.access, but I don't think that it needs to get pulled here, right? I don't have an actual imagestream of that, plus it would just get pulled during initial logging deployments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually write any of the docs from that other PR, they're just a direct copy paste from the upstream repo and the authors there, being moved to help close out a task we had to make sure this was covered. Hopefully @ewolinetz or @sosiouxme can help with any questions.
Upstream repo they came from was https://github.com/openshift/origin-aggregated-logging#upgrading-your-efk-stack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, there's a logging-deployment image but nothing creates an IS for it because it's invoked as a one-off pod from the deployer template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexd I would actually say "the list of ImageStreams are..." - the image names are something more involved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually say "the list of ImageStreams are..." - the image names are something more involved
@sosiouxme Righto, had been going back and forth on that.
Also sorry to "alexd" - you got hit by my IRC nick ;)
LGTM |
@sosiouxme Thanks, updated. @ahardin-rh Can you peer review? Pretty build here: |
$ oc scale dc/logging-es-<unique_name> --replicas=1 | ||
---- | ||
+ | ||
Tail the logs of the resulting pod to ensure that it was able to recover its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a novice user, tail is a new-to-me term. Should a command be added here to show what you mean, or do you think the target audience should already know what is meant here?
@adellape Just one comment. Other than that, LGTM! |
---- | ||
+ | ||
If that is successful, you can then do the same for the operations cluster, if | ||
one was previously used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahardin-rh See above per your suggestion. Changed it from "tail" to "follow" and showed usage of a command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adellape Looks good!
[rev_history] |
Pulls in commit from #1933 and applies edits and moves section to the Manual Upgrades topic.
Pretty build:
http://file.rdu.redhat.com/~adellape/042816/logging-upgrade/install_config/upgrading/manual_upgrades.html#manual-upgrading-logging-components
@dgoodwin @sosiouxme PTAL?
@bfallonf Peer review since you've done logging stuff before?