Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1337328 : Added text mongodb variable #2232

Merged
merged 1 commit into from Jun 10, 2016

Conversation

bfallonf
Copy link

@bfallonf bfallonf commented Jun 8, 2016

@bparees @mfojtik As per email.

I've pretty much just added the variable to the table with a link to the text section of the Mongo docs. I don't think this warrants its own section explaining it. Let me know if you disagree.

Any other thoughts?

@mfojtik
Copy link
Member

mfojtik commented Jun 8, 2016

lgtm

@bparees
Copy link
Contributor

bparees commented Jun 8, 2016

needs a note that it's only applicable to mongodb 2.4 (mongodb 2.6 doesn't have an equivalent setting)

@bfallonf
Copy link
Author

bfallonf commented Jun 8, 2016

@mfojtik @bparees Cool. Thanks! I added a note in parenthesis.

If there's nothing else, @tpoitras @adellape @ahardin-rh @tnguyen-rh could probably have a read/merge/both.

@bparees
Copy link
Contributor

bparees commented Jun 8, 2016

lgtm

@@ -162,15 +162,19 @@ MongoDB settings can be configured with the following environment variables:

|`*MONGODB_NOPREALLOC*`
|Disable data file preallocation.
|true
|True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bparees Do you know whether these are case sensitive? It looks like a spec will accept it init-capped, at least.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know, we stuff the value in the mongo config here:
https://github.com/openshift/mongodb/blob/master/2.4/root/usr/share/container-scripts/mongodb/mongodb.conf.template

so it's up to mongo. i'd guess mongo is not case sensitive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@adellape
Copy link
Contributor

adellape commented Jun 9, 2016

@bfallonf LGTM. Up to you on the inline case sensitivity thing.

@bfallonf
Copy link
Author

@adellape I changed to caps because it wasn't really about what's in the file, but it's the value. I can't imagine people are going to copy/paste one word...

But I changed to being parameter markup and pushed again.

Nothing of note changes. I'll merge away.

@bfallonf
Copy link
Author

[rev_history]
|xref:../using_images/db_images/mongodb.adoc#[Database Images -> MongoDB]
|Added the *MONGODB_TEXT_SEARCH_ENABLED* variable to the xref:../using_images/db_images/mongodb.adoc#environment-variables[Environment Variables] section.
%

@bfallonf bfallonf merged commit 8b40823 into openshift:master Jun 10, 2016
@bfallonf bfallonf added this to the Next Release milestone Jun 10, 2016
@ahardin-rh ahardin-rh modified the milestones: Next Release, Staging 06/13/16, Staging, Published - 6/14/2016 Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants