New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1337328 : Added text mongodb variable #2232
Conversation
lgtm |
needs a note that it's only applicable to mongodb 2.4 (mongodb 2.6 doesn't have an equivalent setting) |
@mfojtik @bparees Cool. Thanks! I added a note in parenthesis. If there's nothing else, @tpoitras @adellape @ahardin-rh @tnguyen-rh could probably have a read/merge/both. |
lgtm |
@@ -162,15 +162,19 @@ MongoDB settings can be configured with the following environment variables: | |||
|
|||
|`*MONGODB_NOPREALLOC*` | |||
|Disable data file preallocation. | |||
|true | |||
|True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bparees Do you know whether these are case sensitive? It looks like a spec will accept it init-capped, at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know, we stuff the value in the mongo config here:
https://github.com/openshift/mongodb/blob/master/2.4/root/usr/share/container-scripts/mongodb/mongodb.conf.template
so it's up to mongo. i'd guess mongo is not case sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@bfallonf LGTM. Up to you on the inline case sensitivity thing. |
@adellape I changed to caps because it wasn't really about what's in the file, but it's the value. I can't imagine people are going to copy/paste one word... But I changed to being parameter markup and pushed again. Nothing of note changes. I'll merge away. |
[rev_history] |
@bparees @mfojtik As per email.
I've pretty much just added the variable to the table with a link to the text section of the Mongo docs. I don't think this warrants its own section explaining it. Let me know if you disagree.
Any other thoughts?