Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ApiServerSource event sources in dev console #22459

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

abrennan89
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@abrennan89 abrennan89 force-pushed the eventsources branch 5 times, most recently from f5aeba7 to 1e960cd Compare June 15, 2020 20:02
@abrennan89 abrennan89 changed the title [WIP] Using serverless event sources in dev console [WIP] Using ApiServerSource event sources in dev console Jun 15, 2020
@matzew
Copy link
Member

matzew commented Jun 16, 2020 via email

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2020
@abrennan89 abrennan89 force-pushed the eventsources branch 3 times, most recently from 45a1e65 to da67178 Compare July 1, 2020 20:29
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 15, 2020
@ahardin-rh
Copy link
Contributor

@abrennan89 Just some minor comments from me. Looks great!

modules/odc-creating-apiserversource.adoc Outdated Show resolved Hide resolved
modules/odc-creating-apiserversource.adoc Outdated Show resolved Hide resolved
modules/odc-creating-apiserversource.adoc Show resolved Hide resolved
modules/odc-creating-apiserversource.adoc Show resolved Hide resolved
@Preeticp
Copy link
Contributor

Preeticp commented Jul 15, 2020

Hi @abrennan89 the DevConsole sections look great. I have left some minor suggestions. Thank you for doing this!

@abrennan89
Copy link
Contributor Author

@Preeticp @ahardin-rh if this looks OK to you both now it should be ready to merge 🙂 I've resolved all the comments except for the additional fields that AFAIK aren't required (see comments).

@abrennan89
Copy link
Contributor Author

@Preeticp this is for OCP 4.5 + 4.6, right?

@Preeticp
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@Preeticp Preeticp removed their assignment Jul 16, 2020
@abrennan89 abrennan89 changed the title [WIP] Using ApiServerSource event sources in dev console Using ApiServerSource event sources in dev console Jul 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2020
@ahardin-rh ahardin-rh added this to the Next Release milestone Jul 16, 2020
@ahardin-rh ahardin-rh merged commit 1a55b5a into openshift:master Jul 16, 2020
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.5

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #23862

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #23863

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the eventsources branch December 17, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants