-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ApiServerSource event sources in dev console #22459
Conversation
The preview will be available shortly at: |
f5aeba7
to
1e960cd
Compare
ApiServerSource works without out a broker as well.
It can sink to Channle, KSVC etc
It does not require a broker to work
On Tue 16. Jun 2020 at 19:48, Ashleigh Brennan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In serverless/event_sources/knative-event-sources.adoc
<#22459 (comment)>
:
> +toc::[]
+
+An _event source_ is a resource object, which is the link between an event producer and a _sink_ (or consumer) that receives those events. Currently, {ServerlessProductName} supports the following event source types:
+
+ApiServerSource:: Connects a sink to the Kubernetes API server.
+PingSource:: Periodically sends ping events with a constant payload. It can be used as a timer.
+
+SinkBinding is also supported, which allows you to connect core Kubernetes resources such as `Deployment`, `Job`, or `StatefulSet` with a sink.
+
+You can create and manage Knative event sources using the Developer perspective, the `kn` CLI, or by applying YAML files.
+
+.Prerequisites
+
+* You must have a current installation of xref:../../serverless/installing_serverless/installing-openshift-serverless.adoc#serverless-install-web-console_installing-openshift-serverless[{ServerlessProductName}], including Knative Serving and Eventing, in your {product-title} cluster. This can be installed by a cluster administrator.
+* You must create the `default` broker in the same namespace that the event source will be installed in. For more information, see xref:../../serverless/knative_eventing/serverless-using-brokers.adoc#serverless-using-brokers[Using brokers with Knative Eventing].
+* You must create or update a service account, role and role binding for event sources.
I'm not saying it needs the service a/c *because* of the broker, I'm just
saying ApiServerSource needs both a service a/c and a broker, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTQKXESBFEJEFUV65IDRW6WABANCNFSM4NNKAMKA>
.
--
Sent from Gmail Mobile
|
45a1e65
to
da67178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@abrennan89 Just some minor comments from me. Looks great! |
Hi @abrennan89 the DevConsole sections look great. I have left some minor suggestions. Thank you for doing this! |
@Preeticp @ahardin-rh if this looks OK to you both now it should be ready to merge 🙂 I've resolved all the comments except for the additional fields that AFAIK aren't required (see comments). |
@Preeticp this is for OCP 4.5 + 4.6, right? |
/lgtm |
/cherrypick enterprise-4.5 |
/cherrypick enterprise-4.6 |
@ahardin-rh: new pull request created: #23862 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahardin-rh: new pull request created: #23863 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.