Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-1554 topology scaling and filters #23652

Merged
merged 1 commit into from Aug 5, 2020
Merged

RHDEVDOCS-1554 topology scaling and filters #23652

merged 1 commit into from Aug 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2020 •
edited by ghost

https://issues.redhat.com/browse/RHDEVDOCS-1554 Describe Display options drop-down list and a search bar/filter in Topology view and fix bad links in module links

  • Reviewed by <QE/SME>
  • peer-reviewed by DT docs
  • peer-reviewed by ocp docs
  • merge to 4.6 and 4.5

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

karthikjeeyar
karthikjeeyar approved these changes Jul 16, 2020
View reviewed changes
Copy link

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ghost
Copy link
Author

ghost commented Jul 17, 2020

@Preeticp could you review pls, it seems to be complete. Thanks!

@Preeticp
Copy link
Contributor

@pmacko1 a minor nit, otherwise it looks good to me, please send it to the OCP team for review. Also please confirm the versions to which this PR needs to be cherry picked and mention it in the description of the PR.

@ghost
Copy link
Author

ghost commented Jul 22, 2020

@Preeticp could you tell me what to do about the versions? thank you

@Preeticp
Copy link
Contributor

@pmacko1 click the Fit to Screen icon is still a valid comment. I don't think this is resolved, please fix it.

@ghost
Copy link
Author

ghost commented Jul 23, 2020

@pmacko1 click the Fit to Screen icon is still a valid comment. I don't think this is resolved, please fix it.

ah, I overlooked what you mean, not really a fan of that review format. I'm gonna add view into that.

@ghost ghost changed the title WIP: RHDEVDOCS-1554 topology scaling and filters RHDEVDOCS-1554 topology scaling and filters Jul 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 31, 2020
@ahardin-rh
Copy link
Contributor

Just some minor comments from me 👍

@ghost
Copy link
Author

ghost commented Jul 31, 2020

@ahardin-rh thanks :) updated

@ghost
Copy link
Author

ghost commented Jul 31, 2020

versions 4.5 and 4.6, very likely

@Preeticp
Copy link
Contributor

Preeticp commented Aug 4, 2020

Ack, @pmacko1 and @ahardin-rh 4.5 and 4.6 is correct. Thank you!

@ghost ghost requested a review from ahardin-rh August 4, 2020 09:33
@ahardin-rh ahardin-rh added this to the Next Release milestone Aug 5, 2020
@ahardin-rh
Copy link
Contributor

Looks great!

@ahardin-rh ahardin-rh merged commit bcff4cf into openshift:master Aug 5, 2020
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.5

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #24476

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #24477

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahardin-rh ahardin-rh Awaiting requested review from ahardin-rh

Assignees
No one assigned
Labels
branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-docs-preview-bot @Preeticp @ahardin-rh @openshift-cherrypick-robot @karthikjeeyar @openshift-ci-robot