RN-CNV-5472 Supported Guest OS Templates #23741
Conversation
openshift-ci-robot
added
the
size/S
lmandavi
force-pushed
the
RN-CNV-5472-Guest-OS
branch
from
5a12384
to
12f4a25
Compare
|
@fabiand @oyahud - Please review and add LGTM so that this PR can move to peer review stage. |
|
/lgtm |
|
@omeryahud: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Feedback received from Fabian via Google Docs was incorporated. QE review by @omeryahud is complete. Requesting peer review. |
lmandavi
force-pushed
the
RN-CNV-5472-Guest-OS
branch
from
97ca6e7
to
650cb9f
Compare
|
Requesting peer review. |
ousleyp
added
the
peer-review-done
lmandavi
force-pushed
the
RN-CNV-5472-Guest-OS
branch
2 times, most recently
from
8ea4f22
to
7dccb5b
Compare
virt/virt-2-4-release-notes.adoc
Outdated
| {VirtProductName} guests can use the following operating systems: | ||
|
|
||
| ** Red Hat Enterprise Linux 6, 7, 8. | ||
| ** Microsoft Windows Server 2012 R2, 2016, and 2019. | ||
| ** Microsoft Windows 10. |
There was a problem hiding this comment.
- Please change the
**s to*now that you've removed the initial bullet point. - Please add
and:* Red Hat Enterprise Linux 6, 7, and 8.(parallel structure with the next line)
There was a problem hiding this comment.
@ousleyp Requesting clarification, I didn't understand the comments. Can you show how you want the bullets and the text to be displayed (the complete structure). Thanks.
There was a problem hiding this comment.
Content was updated.
virt/virt-2-4-release-notes.adoc
Outdated
| ** Red Hat Enterprise Linux 6, 7, 8. | ||
| ** Microsoft Windows Server 2012 R2, 2016, and 2019. | ||
| ** Microsoft Windows 10. | ||
| + |
There was a problem hiding this comment.
Please remove the + so that this statement aligns with the intro sentence (now that the initial bullet point has been removed).
There was a problem hiding this comment.
@ousleyp Request clarification. I didn't understand this comment. Please show the actual structure of you want it. Thanks.
There was a problem hiding this comment.
For both of these comments, please see if the asciidoc reference clarifies things: https://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#lists
Regarding the +, see the "list continuation" example in the section titled "Complex content in outline lists" and let me know if you still have questions. Thanks!
There was a problem hiding this comment.
Content was updated.
This is a combination of 2 commits July 14 afternoon. This is a combination of 2 commits on July 14. This is a combination of 3 commits on July 14. initial draft remove fedora bullet order content reorder remove redundant quote mark peer review input
lmandavi
force-pushed
the
RN-CNV-5472-Guest-OS
branch
from
7dccb5b
to
d0f0a60
Compare
|
PR is ready to be merged. Thank you! |
This PR is associated with https://issues.redhat.com/browse/CNV-5472.