Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-CNV Defect 1855067 volume container disk #23992

Merged

Conversation

lmandavi
Copy link
Contributor

This PR is associated with the defect https://bugzilla.redhat.com/show_bug.cgi?id=1855067.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2020
@lmandavi
Copy link
Contributor Author

@rmohr @fabiand This PR is ready for review.

@lmandavi
Copy link
Contributor Author

@aburdenthehand - keeping you posted about this PR.

@lmandavi
Copy link
Contributor Author

@rmohr please review the updated content.

Copy link

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@lmandavi
Copy link
Contributor Author

Adding @sbream for awareness.

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and a suggestion. Let me know when you've made the changes and squashed your commits. Thanks!

virt/virt-2-4-release-notes.adoc Outdated Show resolved Hide resolved
virt/virt-2-4-release-notes.adoc Outdated Show resolved Hide resolved

* KubeMacPool is disabled in {VirtProductName} {VirtVersion}. This means that a secondary
interface of a Pod or virtual machine obtains a randomly generated MAC address rather
than a unique one from a pool. Although rare, randomly assigned MAC addresses can conflict.
(link:https://bugzilla.redhat.com/show_bug.cgi?id=1816971[*BZ#1816971*])
//Merge conflict resolution - adding this text back on July 21: //Bug 1795410 - this known issue was open when I checked on July 17th.
//BZ#1855067.
* Due to an unknown reason, the memory consumption for the volume type `containerDisk` may increase slowly and exceed the memory limit. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1855067[*BZ#1855067*])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/may/might (IBM style)

virt/virt-2-4-release-notes.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

initial draft

review input

peer review
@lmandavi
Copy link
Contributor Author

@pousley - peer review input was incorporated.
@Ncredi - workaround was added.

@ousleyp ousleyp added this to the Next Release milestone Jul 23, 2020
@ousleyp ousleyp merged commit 35add74 into openshift:enterprise-4.5 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants