BZ1849434 updating vCenter folder #24161

kalexand-rh · 2020-07-24T15:48:07Z

https://bugzilla.redhat.com/show_bug.cgi?id=1849434

@patrickdillon, will you PTAL?

modules/installation-vsphere-machines.adoc

modules/installation-vsphere-config-yaml.adoc

openshift-docs-preview-bot · 2020-07-24T16:06:59Z

The preview will be available shortly at:

https://BZ1849434--ocpdocs.netlify.com/

patrickdillon

I hope these comments clarify. Please let me know if they are unclear. I will open a PR to help clarify the repo docs.

patrickdillon · 2020-07-24T19:19:04Z

modules/installation-vsphere-config-yaml.adoc

@@ -99,30 +100,31 @@ in vSphere.
 <9> The password associated with the vSphere user.
 <10> The vSphere datacenter.
 <11> The default vSphere datastore to use.
-<12> Whether to enable or disable FIPS mode. By default, FIPS mode is not enabled. If FIPS mode is enabled, the {op-system-first} machines that {product-title} runs on bypass the default Kubernetes cryptography suite and use the cryptography modules that are provided with {op-system} instead.
+<12> Optional: The absolute path of an existing folder where the installation program creates the virtual machines, for example, `/<datacenter_name>/vm/<folder_name>/<subfolder_name>`. If you do not provide this value, the installation program creates a folder that is named with the infrastructure ID in the datacenter virtual machine folder.


Suggested change

<12> Optional: The absolute path of an existing folder where the installation program creates the virtual machines, for example, `/<datacenter_name>/vm/<folder_name>/<subfolder_name>`. If you do not provide this value, the installation program creates a folder that is named with the infrastructure ID in the datacenter virtual machine folder.

<12> Optional: The absolute path of an existing folder where the installation program creates the virtual machines, for example, `/<datacenter_name>/vm/<folder_name>/<subfolder_name>`. If you do not provide this value, the installation program points to a top-level folder that is named with the infrastructure ID in the datacenter virtual machine folder.

patrickdillon · 2020-07-24T19:35:02Z

modules/installation-user-infra-generate-k8s-manifest-ignition.adoc

+ifdef::vsphere[]
+. Provide the name of the vCenter folder that hosts your cluster's virtual machines to the cloud provider:
+.. Open the `<installation_directory>/manifests/cloud-provider-config.yaml` file.
+.. Set the value of the `folder` parameter to match the value that you specified for the folder name in the `install-config.yaml` file or, if you did not specify a folder name, the cluster ID.


This section is not quite right, and I don't think we actually need it. This line is describing what the folder value in the cloud-provider-config will already be--no users steps are needed to achieve this.

patrickdillon · 2020-07-24T19:36:18Z

modules/installation-vsphere-machines.adoc

@@ -118,7 +118,7 @@ endif::openshift-origin[]
 .. Right-click the name of your datacenter.
 .. Click *New Folder* -> *New VM and Template Folder*.
 .. In the window that is displayed, enter the folder name. The folder name must
-match the cluster name that you specified in the `install-config.yaml` file.
+match the folder name that you specified in the `install-config.yaml` file or, if you did not specify a folder name, the infrastructure ID.


Should we specify how to get infrastructure ID?

We have instructions in AWS UPI: https://bz1849434--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-user-infra.html#installation-extracting-infraid_installing-aws-user-infra

kalexand-rh · 2020-07-24T20:27:00Z

@patrickdillon, thank you so much! I've pushed some changes to try to address your feedback. Will you let me know if anything else is amiss?

patrickdillon

looks much better. I did leave a couple more comments becuase I am really trying to get this right so we can be done with it :)

patrickdillon · 2020-07-24T22:12:44Z

modules/installation-configuration-parameters.adoc

@@ -482,7 +482,7 @@ in vSphere.
 |String.

 |`platform.vsphere.folder`
-|_Optional_. The absolute path of an existing folder where the installation program creates the virtual machines. create VMs. If you do not provide this value, the installation program creates a folder that is named with the cluster ID is created in the datacenter virtual machine folder.
+|_Optional_. The absolute path of an existing folder where the installation program creates the virtual machines. If you do not provide this value, the installation program creates a folder that is named with the infrastructure ID in the datacenter virtual machine folder.


This is only true for IPI. For UPI I would suggest:

"The absolute path to the virtual machine folder. The default value is a top-level folder named with the infrastructure ID.`

But I think this is shared beween IPI and UPI so not sure how to do that. My suggestion would technically be true for both cases, but is a little less informative for IPI.

I think most of the platform fields in install config was only valid for IPI because UPI is just pausing before IPI and then doing what the installer would have done ourselves because that allows user to do things differently. So i'm fine if this most accurate for IPI.

patrickdillon · 2020-07-24T22:23:30Z

modules/installation-vsphere-machines.adoc

@@ -118,7 +118,7 @@ endif::openshift-origin[]
 .. Right-click the name of your datacenter.
 .. Click *New Folder* -> *New VM and Template Folder*.
 .. In the window that is displayed, enter the folder name. The folder name must
-match the cluster name that you specified in the `install-config.yaml` file.
+match the folder name that you specified in the `install-config.yaml` file or, if you did not specify a folder name, the infrastructure ID.


Not sure if this is acceptable for UPI but it is probably simpler to say "if you didn't specify an existing folder in the install-config, then create a folder..."

Suggested change

match the folder name that you specified in the `install-config.yaml` file or, if you did not specify a folder name, the infrastructure ID.

the infrastructure ID.

One reason I say this is because the instructions technically describe how to create a top-level folder where users could specify a nested folder

jinyunma · 2020-08-04T04:50:48Z

Sorry for the late. The content looks good to me.
One comment: folder update is only applicable on 4.5 and later release. @patrickdillon could you help to confirm?

jinyunma · 2020-08-06T14:43:56Z

Sorry for the late. The content looks good to me.
One comment: folder update is only applicable on 4.5 and later release. @patrickdillon could you help to confirm?

Patrick is on the leave. @abhinavdahiya could you please help to confirm this? thanks.

abhinavdahiya · 2020-08-18T23:35:12Z

LGTM

abhinavdahiya · 2020-08-18T23:35:21Z

/lgtm

openshift-ci-robot · 2020-09-22T19:12:44Z

New changes are detected. LGTM label has been removed.

kalexand-rh · 2020-09-22T19:12:59Z

@jinyunma, will you PTAL?

jinyunma · 2020-09-23T00:55:46Z

New added part Extracting the infrastructure name seems missed in section Installing a cluster on vSphere with user-provisoned infrastructure and network customizations
"

kalexand-rh · 2020-09-23T17:55:24Z

@jinyunma, thanks for pointing that out. I've added the Extracting the infrastructure name section to Installing a cluster on vSphere with user-provisoned infrastructure and network customizations. Do you see any other changes?

jinyunma · 2020-09-28T08:28:44Z

I read again the doc and have one comment:
sample install-config.yaml the description of option12 folder. For upi installation, installer program doesn't create folder named with infrastructure ID if user doesn't define folder in cluster-config.yaml, but need user to create folder named infrastructure ID. other parts are LGTM.

kalexand-rh · 2020-09-28T15:44:57Z

Thank you @jinyunma! I've noted that that parameter is only valid for IPI.

adellape

👍

jinyunma · 2020-09-29T00:09:35Z

@kalexand-rh, thanks for update, it looks good to me.

kalexand-rh · 2020-09-29T18:39:36Z

/cherrypick enterprise-4.5

kalexand-rh · 2020-09-29T18:39:40Z

/cherrypick enterprise-4.6

openshift-cherrypick-robot · 2020-09-29T18:39:46Z

@kalexand-rh: new pull request created: #25865

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-09-29T18:39:49Z

@kalexand-rh: new pull request created: #25866

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kalexand-rh added branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 labels Jul 24, 2020

kalexand-rh added this to the Next Release milestone Jul 24, 2020

kalexand-rh self-assigned this Jul 24, 2020

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2020

abhinavdahiya reviewed Jul 24, 2020

View reviewed changes

modules/installation-vsphere-machines.adoc Outdated Show resolved Hide resolved

abhinavdahiya reviewed Jul 24, 2020

View reviewed changes

modules/installation-vsphere-config-yaml.adoc Outdated Show resolved Hide resolved

patrickdillon reviewed Jul 24, 2020

View reviewed changes

patrickdillon mentioned this pull request Jul 24, 2020

vSphere UPI docs: clarify folder naming openshift/installer#3959

Merged

patrickdillon reviewed Jul 24, 2020

View reviewed changes

openshift-ci-robot assigned abhinavdahiya Aug 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020

kalexand-rh force-pushed the BZ1849434 branch from 373e6d5 to c91fbe2 Compare September 22, 2020 19:12

kalexand-rh removed the branch/enterprise-4.4 label Sep 22, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020

kalexand-rh force-pushed the BZ1849434 branch from c91fbe2 to 48d067f Compare September 22, 2020 19:17

kalexand-rh force-pushed the BZ1849434 branch from 48d067f to ea1a6e7 Compare September 23, 2020 17:54

kalexand-rh force-pushed the BZ1849434 branch from ea1a6e7 to d25c1ec Compare September 28, 2020 15:44

adellape approved these changes Sep 28, 2020

View reviewed changes

adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 28, 2020

BZ1849434 updating vCenter folder

663b959

kalexand-rh force-pushed the BZ1849434 branch from d25c1ec to 663b959 Compare September 29, 2020 18:07

kalexand-rh merged commit 4532da0 into openshift:master Sep 29, 2020

kalexand-rh deleted the BZ1849434 branch September 29, 2020 18:39

This was referenced Sep 29, 2020

[enterprise-4.5] BZ1849434 updating vCenter folder #25865

Merged

[enterprise-4.6] BZ1849434 updating vCenter folder #25866

Merged

bergerhoffer mentioned this pull request Mar 23, 2021

[enterprise-4.2] Edit suggested in file installing/installing_vsphere/installing-vsphere.adoc #20360

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BZ1849434 updating vCenter folder #24161

BZ1849434 updating vCenter folder #24161

kalexand-rh commented Jul 24, 2020

openshift-docs-preview-bot commented Jul 24, 2020

patrickdillon left a comment

patrickdillon Jul 24, 2020

patrickdillon Jul 24, 2020

patrickdillon Jul 24, 2020

kalexand-rh commented Jul 24, 2020

patrickdillon left a comment

patrickdillon Jul 24, 2020

abhinavdahiya Aug 18, 2020

patrickdillon Jul 24, 2020

jinyunma commented Aug 4, 2020

jinyunma commented Aug 6, 2020

abhinavdahiya commented Aug 18, 2020

abhinavdahiya commented Aug 18, 2020

openshift-ci-robot commented Sep 22, 2020

kalexand-rh commented Sep 22, 2020

jinyunma commented Sep 23, 2020

kalexand-rh commented Sep 23, 2020

jinyunma commented Sep 28, 2020

kalexand-rh commented Sep 28, 2020

adellape left a comment

jinyunma commented Sep 29, 2020 •

edited

kalexand-rh commented Sep 29, 2020

kalexand-rh commented Sep 29, 2020

openshift-cherrypick-robot commented Sep 29, 2020

openshift-cherrypick-robot commented Sep 29, 2020

	<12> Optional: The absolute path of an existing folder where the installation program creates the virtual machines, for example, `/<datacenter_name>/vm/<folder_name>/<subfolder_name>`. If you do not provide this value, the installation program creates a folder that is named with the infrastructure ID in the datacenter virtual machine folder.
	<12> Optional: The absolute path of an existing folder where the installation program creates the virtual machines, for example, `/<datacenter_name>/vm/<folder_name>/<subfolder_name>`. If you do not provide this value, the installation program points to a top-level folder that is named with the infrastructure ID in the datacenter virtual machine folder.

	match the folder name that you specified in the `install-config.yaml` file or, if you did not specify a folder name, the infrastructure ID.
	the infrastructure ID.

BZ1849434 updating vCenter folder #24161

BZ1849434 updating vCenter folder #24161

Conversation

kalexand-rh commented Jul 24, 2020

openshift-docs-preview-bot commented Jul 24, 2020

patrickdillon left a comment

Choose a reason for hiding this comment

patrickdillon Jul 24, 2020

Choose a reason for hiding this comment

patrickdillon Jul 24, 2020

Choose a reason for hiding this comment

patrickdillon Jul 24, 2020

Choose a reason for hiding this comment

kalexand-rh commented Jul 24, 2020

patrickdillon left a comment

Choose a reason for hiding this comment

patrickdillon Jul 24, 2020

Choose a reason for hiding this comment

abhinavdahiya Aug 18, 2020

Choose a reason for hiding this comment

patrickdillon Jul 24, 2020

Choose a reason for hiding this comment

jinyunma commented Aug 4, 2020

jinyunma commented Aug 6, 2020

abhinavdahiya commented Aug 18, 2020

abhinavdahiya commented Aug 18, 2020

openshift-ci-robot commented Sep 22, 2020

kalexand-rh commented Sep 22, 2020

jinyunma commented Sep 23, 2020

kalexand-rh commented Sep 23, 2020

jinyunma commented Sep 28, 2020

kalexand-rh commented Sep 28, 2020

adellape left a comment

Choose a reason for hiding this comment

jinyunma commented Sep 29, 2020 • edited

kalexand-rh commented Sep 29, 2020

kalexand-rh commented Sep 29, 2020

openshift-cherrypick-robot commented Sep 29, 2020

openshift-cherrypick-robot commented Sep 29, 2020

jinyunma commented Sep 29, 2020 •

edited