Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index Management underestimate number of documents in the index to rollover #24198

Merged
merged 1 commit into from Jul 30, 2020
Merged

Index Management underestimate number of documents in the index to rollover #24198

merged 1 commit into from Jul 30, 2020

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jul 27, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2020
@mburke5678
Copy link
Contributor Author

@lukas-vlcek @QiaolingTang Please take a look. PR to change the reference to the number of index documents that triggers Elasticsearch rollover

@mburke5678 mburke5678 added this to the Next Release milestone Jul 27, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

anpingli
anpingli reviewed Jul 30, 2020
View reviewed changes
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adellape
adellape reviewed Jul 30, 2020
View reviewed changes
modules/cluster-logging-elasticsearch-retention.adoc Outdated
* The index size is greater than 40gb x number of primary shards.
* The index doc count is greater than 40960 x number of primary shards.
* The index size is greater than 40gb x the number of primary shards.
* The index doc count is greater than 40960k x the number of primary shards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per IBM SG seems the style should be:

40 GB × the number [...]
40960 KB × the number [...]

Uppercase abbrev with a space and with (×) being an actual multiplication sign.

@mburke5678 mburke5678 merged commit 1ed1d70 into openshift:master Jul 30, 2020
@mburke5678 mburke5678 deleted the BZ-1860135 branch July 30, 2020 15:27
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #24343

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #24344

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adellape adellape adellape left review comments

@anpingli anpingli anpingli left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.5 branch/enterprise-4.6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mburke5678 @openshift-docs-preview-bot @openshift-cherrypick-robot @adellape @anpingli @openshift-ci-robot