Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1349727 added important box about changing fstype field #2469

Merged
merged 1 commit into from Jul 18, 2016

Conversation

bfallonf
Copy link

@bfallonf bfallonf commented Jul 6, 2016

As per: https://bugzilla.redhat.com/show_bug.cgi?id=1349727#c0

I'll ask for an ack in the BZ.

@bfallonf bfallonf added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-3.1 branch/enterprise-3.2 labels Jul 15, 2016
@bfallonf bfallonf added this to the Next Release milestone Jul 15, 2016
@bfallonf
Copy link
Author

Ack given.

@tpoitras @ahardin-rh @adellape @tnguyen-rh Peer review plz?

@bfallonf
Copy link
Author

[rev_history]
|xref:../install_config/persistent_storage/index.adoc[Configuring Persistent Storage]
|Added important box about changing fstype field in a persistent volume configuration in several files.
%

[IMPORTANT]
====
Changing the value of the `*fstype*` parameter after the volume has been
formatted and provisioned is not recommended, and can result in data loss and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were supposed to avoid wording things as "recommendations" and instead just tell them why something is a bad idea?

"Changing the value of the fstype parameter after the volume has been formatted and provisioned can result in data loss and pod failure."

@tpoitras
Copy link

@bfallonf left some notes, you can probably ignore my corrections of "s/will format/formats" if you want, because you're quantify the "when" with "before...", but changing it as I've noted will future-proof it against accidentally lapsing into unnecessary future tense if the sentence is reworded and the before is removed.

@bfallonf
Copy link
Author

@tpoitras Nah, I agree with all you said. Thanks for the review. I will merge.

@bfallonf bfallonf merged commit 1e662b2 into openshift:master Jul 18, 2016
@bfallonf bfallonf removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 26, 2016
@bfallonf bfallonf modified the milestones: Next Release, Staging Jul 26, 2016
@vikram-redhat vikram-redhat modified the milestones: Staging, Staging - Picked Jul 27, 2016
@vikram-redhat vikram-redhat modified the milestones: Staging - Picked, Staging, Published - 07/27/16 Jul 27, 2016
@bfallonf bfallonf deleted the bz1349727 branch September 15, 2016 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants