update information about OAuth grant strategies #2488
Conversation
|
@liggitt PTAL |
|
@stevekuznetsov PTAL also (since I based this on your original PR) |
| secret: "...", <2> | ||
| redirectURIs: | ||
| - http://www.example.com/ <3> | ||
| grantMethod: "...", <4> |
There was a problem hiding this comment.
this looks like it's switching from json to invalid yaml
I would also make the sample data one of the valid values
grantMethod: prompt
|
@liggitt Does this look better? |
|
yup, LGTM |
| ---- | ||
| <1> The `name` of the OAuth client is used as the `client_id` parameter when making requests to `_<master>_/oauth/authorize` and `_<master>_/oauth/token`. | ||
| <2> The `secret` is used as the `client_secret` parameter when making requests to `_<master>_/oauth/token`. | ||
| <3> The `redirect_uri` parameter specified in requests to `_<master>_/oauth/authorize` and `_<master>_/oauth/token` must be equal to (or prefixed by) one of the URIs in `redirectURIs`. | ||
| <4> The `grantMethod` is used to determine what action to take when this client requests tokens and has not yet been granted access by the user. Uses the same values seen in link:./../../install_config/configuring_authentication.html#grant-options[Grant Options]. |
There was a problem hiding this comment.
We are now using xrefs instead of links for internal paths, so:
s/link:../../../install_config/configuring_authentication.html#grant-options[Grant Options]/xref:configuring_authentication.adoc#grant-options[Grant Options]
|
@sgallagher just one little comment from me. Other than that, looks good! |
|
@ahardin-rh Updated, PTAL |
|
@sgallagher I messed up. Sorry! The path should still have install_config/ before it. So: Sorry for the hassle! 😵 |
|
@sgallagher please also check my labels here. I am assuming this is for 3.3. |
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
|
@ahardin-rh No problem. Fixed. Yes, this is for 3.3 (it matches a feature added in that release). |
|
@sgallagher Perfect. Thanks! |
|
[rev_history] |
Modified from and replaces #1682
Supplements openshift/origin#9616