Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ1866588 - modifying registry login method #25833

Merged
merged 1 commit into from Sep 29, 2020

Conversation

kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh added this to the Next Release milestone Sep 28, 2020
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 28, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

. Edit the new
endif::[]
ifdef::openshift-origin[]
. Create a `.json`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrutkovs, does this pull secret file seem reasonable for OKD?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, lgtm

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 29, 2020
@ahardin-rh
Copy link
Contributor

LGTM!

@kalexand-rh kalexand-rh merged commit f77dea1 into openshift:master Sep 29, 2020
@kalexand-rh kalexand-rh deleted the BZ1866588 branch September 29, 2020 17:39
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.3

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.4

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.5

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #25857

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #25858

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #25859

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #25860

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants