Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glibc version 2.28+ limitation for using opm #27181

Merged
merged 1 commit into from Dec 1, 2020

Conversation

bysnupy
Copy link
Member

@bysnupy bysnupy commented Nov 9, 2020

At this time our proposed solution is to update the official openshift 4.6 docs to describe these limitations for the opm build on linux.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2020
@kalexand-rh
Copy link
Contributor

@jianzhangbjz, will you PTAL and confirm that this change is valid for versions 4.6+?

Copy link

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc looks great but I'm a little concerned it's written explicitly for linux users.

opm does not have a hard requirement on podman, users can use docker as a container tool instead. podman is also linux only.

For mac/windows the glibc requirement is not required, since the binary is statically linked on those platforms.

My suggestion would be to put Prerequisites (linux) or something like that to express that these prerequisites are for linux users only. Also there are bugs in podman 1.x that currently affect opm, maybe we could recommend using podman 2.x as well.

@kalexand-rh
Copy link
Contributor

@exdx, which specific version of podman is better to list as the minimum?

@exdx
Copy link

exdx commented Nov 10, 2020

@exdx, which specific version of podman is better to list as the minimum?

We (OLM) haven't documented a specific version to recommend for users, so I couldn't say for sure. But here is an example of a recent bug in opm that was due to an underlying podman issue that was fixed in v2.0.0+

https://bugzilla.redhat.com/show_bug.cgi?id=1894167

That being said older versions of podman will work fine for general use cases but can run into edge cases like the one above.

So I think something like podman version 1.4.4+ (version 2.0+ recommended) is fair

@bysnupy
Copy link
Member Author

bysnupy commented Nov 11, 2020

@kalexand-rh What about changing it as follows ? Or if you have any suggestion, let me know that please. I can modify our best result. I remember the podman version is written on the multiple sections in the docs. It has potential issue due to the bug. So I think we had better change all places related with those places either.

Prerequisites for Linux
* `podman` version 1.4.4+ (version 2.0+ recommended)
* `glibc` version 2.28+

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@bysnupy
Copy link
Member Author

bysnupy commented Nov 13, 2020

I've changed as I previously mentioned. I think we need another PR to change additional the podman recommend version in the related other places. It's different topic with this PR.

@bysnupy
Copy link
Member Author

bysnupy commented Nov 16, 2020

@kalexand-rh Could you PTAL ?

@kalexand-rh
Copy link
Contributor

@jianzhangbjz, will you PTAL?

modules/olm-installing-opm.adoc Outdated Show resolved Hide resolved
If the linux has not glibc more than v2.28,
you can face "error /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by ./opm)" error, when you run the "opm".
And podman version is recommended 2.0+ for suppressing potential bug implication.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1892004#c3
           https://bugzilla.redhat.com/show_bug.cgi?id=1894167
@kalexand-rh
Copy link
Contributor

I think this change looks good, and I'll merge it as soon as @jianzhangbjz approves it.

@jianzhangbjz
Copy link

Sorry for the late reply! Looks good to me, thanks all!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@bysnupy
Copy link
Member Author

bysnupy commented Dec 1, 2020

@kalexand-rh Would you PTAL if you have time ? Thank you for your review.

@kalexand-rh kalexand-rh merged commit c56a600 into openshift:master Dec 1, 2020
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 1, 2020

/cherrypick enterprise-4.6

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 1, 2020

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 1, 2020

@kalexand-rh: new pull request created: #27744

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 1, 2020

@kalexand-rh: new pull request created: #27745

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abdennour
Copy link

I still get same error in WSL ( which is ubuntu 18.04). I am using opm downloaded from https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/latest-4.9/?extIdCarryOver=true&sc_cid=7013a00000316d9AAA .

Is it it the right binary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants