Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a note on CNV with OLM disconnected or proxy #27467

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Added a note on CNV with OLM disconnected or proxy #27467

merged 1 commit into from
Nov 19, 2020

Conversation

e-minguez
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2020
@kalexand-rh
Copy link
Contributor

@ousleyp, @aburdenthehand, PTAL?

ousleyp
ousleyp reviewed Nov 18, 2020
View reviewed changes
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! I have some suggested edits; please let me know if you have any questions.

virt/install/preparing-cluster-for-virt.adoc Outdated Show resolved Hide resolved
@ousleyp ousleyp added this to the Next Release milestone Nov 18, 2020
@ousleyp ousleyp added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Nov 18, 2020
@ousleyp
Copy link
Member

ousleyp commented Nov 19, 2020

Because this is a trivial change, @aburdenthehand and I do not think it requires QE. I'm going to go ahead and merge it. Thanks @e-minguez! Awesome work :)

@ousleyp ousleyp merged commit 3fdf2a7 into openshift:master Nov 19, 2020
@ousleyp
Copy link
Member

ousleyp commented Nov 19, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.5

@ousleyp
Copy link
Member

ousleyp commented Nov 19, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 19, 2020 •
edited by openshift-ci-robot

@ousleyp: new pull request created: #27511

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp
Copy link
Member

ousleyp commented Nov 19, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 19, 2020 •
edited by openshift-ci-robot

@ousleyp: new pull request created: #27512

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 19, 2020 •
edited by openshift-ci-robot

@ousleyp: new pull request created: #27513

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2020
Merged
@e-minguez
Copy link
Contributor Author

Because this is a trivial change, @aburdenthehand and I do not think it requires QE. I'm going to go ahead and merge it. Thanks @e-minguez! Awesome work :)

Thanks, it was an easy one :)

I'm curious, how long does it take to be published in the official docs?

@ousleyp
Copy link
Member

ousleyp commented Nov 19, 2020

@e-minguez It is up on docs.openshift.com now: https://docs.openshift.com/container-platform/4.6/virt/install/preparing-cluster-for-virt.html :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousleyp ousleyp ousleyp left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@e-minguez @kalexand-rh @ousleyp @openshift-cherrypick-robot @openshift-ci-robot