Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ-1886892: Adding note to set 'GODEBUG=x509ignoreCN=0' #27524

Merged
merged 1 commit into from
Dec 4, 2020
Merged

BZ-1886892: Adding note to set 'GODEBUG=x509ignoreCN=0' #27524

merged 1 commit into from
Dec 4, 2020

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Nov 19, 2020 •
edited

@bergerhoffer bergerhoffer added this to the Next Release milestone Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@ahardin-rh
Copy link
Contributor

@bergerhoffer Just one suggestion from me. Thanks!

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2020
@bergerhoffer
Copy link
Contributor Author

@sallyom Can you please review this update per your request in https://bugzilla.redhat.com/show_bug.cgi?id=1886892? Thanks!

@sallyom
Copy link

sallyom commented Nov 30, 2020

this lgtm, the preview is cut off for some reason, but the code looks good, thanks

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2020
@sallyom
Copy link

sallyom commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@bergerhoffer
Copy link
Contributor Author

@zhouying7780 Can you please review this update to notify users to use GODEBUG=x509ignoreCN=0 if they use certs that don't set a SAN?

Preview: https://bz-1886892-update--ocpdocs.netlify.app/openshift-enterprise/latest/installing/install_config/installing-restricted-networks-preparations.html#installation-mirror-repository_installing-restricted-networks-preparations

@zhouying7780
Copy link

/lgtm

@bergerhoffer bergerhoffer merged commit 81376ba into openshift:master Dec 4, 2020
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 4, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 4, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.6

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 4, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.5

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 4, 2020 •
edited by openshift-ci-robot

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2020 •
edited by openshift-ci-robot

@bergerhoffer: new pull request created: #27864

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2020 •
edited by openshift-ci-robot

@bergerhoffer: new pull request created: #27865

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2020 •
edited by openshift-ci-robot

@bergerhoffer: new pull request created: #27866

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 4, 2020
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2020 •
edited by openshift-ci-robot

@bergerhoffer: new pull request created: #27867

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the BZ-1886892-update branch August 3, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

Assignees

@zhouying7780 zhouying7780

@sallyom sallyom

Labels
branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bergerhoffer @openshift-docs-preview-bot @ahardin-rh @sallyom @zhouying7780 @openshift-cherrypick-robot @openshift-ci-robot