OSSMDOC-175 Correct Jaeger/ES installation/config. #27568
Conversation
openshift-ci-robot
added
the
size/S
|
The preview will be available shortly at: |
|
Thanks for the quick turnaround but please hold on for the changes, I'm waiting for the CU feedback to corroborate the proper Elasticsearch parameters within Jaeger specs here, in principle, the new draft could be as follows: Best Regards. |
|
Hi all, I think the following could be a better example for the Jaeger configuration, it includes the configuration that worked for the CU and also from my side (it's based also in QA template): Please double check, thanks. |
|
As a side note, I think that section Deploying the Red Hat OpenShift Service Mesh control plane should also reflect that Jaeger is in not production mode by default and point to the Jaeger customization here. If you see the template within the Deploying the control plane from the CLI, you can see we also provide non-production "Memory" mode as example. Best Regards. |
|
Hi all, another thing to review as part of this PR is the following afirmation about Jaeger extracted from here, obviously is not correct, by default is using "Memory" mode: Thanks. |
JStickler
force-pushed
the
OSSMDOC-175
branch
from
506a8e0
to
251ed2d
Compare
openshift-ci-robot
added
size/M
|
@pamoedom, I updated the example configuration (minus a line or two that are defaults so no need to specify them). I'm working on another PR for https://issues.redhat.com/browse/OSSMDOC-176 that already addresses some of the comments you've made here that we need to warn customers about the default configuration, that I didn't want to duplicate here. |
Thanks @JStickler, looks good to me. |
|
@JStickler on the doc https://ossmdoc-175--ocpdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/upgrading-ossm.html
|
|
I used this CR (copied possible values from the PR) and I do not see an issue. expect the review comment #27568 (review) apiVersion: maistra.io/v2
kind: ServiceMeshControlPlane
metadata:
namespace: istio-system
name: basic
spec:
tracing:
sampling: 10000 # 1 is 0.01% and 10000 is 100%, example: 100 = 1%
type: Jaeger
addons:
jaeger:
name: jaeger
install:
ingress:
enabled: true
storage:
type: Memory # or Elasticsearch for production mode
memory:
maxTraces: 100000
elasticsearch: # the following values only apply if storage:type:=Elasticsearch
storage: # specific storageclass configuration for the Jaeger Elasticsearch (optional)
size: "10G"
storageClassName: "managed-premium"
nodeCount: 3
redundancyPolicy: SingleRedundancy
kiali:
enabled: true
prometheus:
enabled: true
runtime:
components:
tracing.jaeger: {} # general Jaeger specific runtime configuration (optional)
tracing.jaeger.elasticsearch: #runtime configuration for Jaeger Elasticsearch deployment (optional)
container:
resources:
requests:
memory: "1Gi"
cpu: "500m"
limits:
memory: "1Gi"
version: v2.0
telemetry:
type: Istiodstorage type as "Memory"storage type as "Elasticsearch" |
|
cc @objectiser |
JStickler
force-pushed
the
OSSMDOC-175
branch
from
251ed2d
to
2102de2
Compare
|
Thanks, @JStickler looks good to me. |
|
/cherry-pick enterprise-4.6 |
|
/cherry-pick enterprise-4.7 |
|
@neal-timpe: new pull request created: #28391 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@neal-timpe: new pull request created: #28392 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses feedback from #27514 and #27515.