Bug 1354522, describe parameters mentioned in master-config.yaml #2764
Conversation
ahardin-rh
force-pushed
the
master-config-files
branch
from
ca99eb3
to
522b4b8
Compare
| |=== | ||
|
|
||
|
|
||
| === etc Configuration |
ahardin-rh
force-pushed
the
master-config-files
branch
3 times, most recently
from
26db437
to
f1b2d70
Compare
ahardin-rh
changed the title
| To create a xref:node-configuration-files[node configuration file] and other | ||
| related files in the specified directory: | ||
| |`*ControllerArguments*` | ||
| |Key value pairs that will be passed directly to the Kube controller manager |
There was a problem hiding this comment.
@ahardin-rh I just did a search, and sometimes in the docs we use "key-value". I'm not sure which is more accurate, but I'd lean towards that one. We're pretty loose with this though, so I'd say both are acceptable. Developing a standard might be a good idea for the future (brice thinks to himself...).
|
@ahardin-rh Some typo-level comments. Overall, looks good! |
ahardin-rh
force-pushed
the
master-config-files
branch
from
f1b2d70
to
582d351
Compare
|
@bfallonf Thanks for the review! 🔍 |
| terminate. For nodes, a configuration file can be written using the `oadm | ||
| create-node-config` command. Creating new configuration files is useful to get a | ||
| starting point for defining your configuration. | ||
| You can xref:creating-new-configuration-files[create a new node configuration |
There was a problem hiding this comment.
"create a new master configuration file", not node.
|
Is there any plan to describe parameters mentioned in node-config.yaml?thanks |
ahardin-rh
force-pushed
the
master-config-files
branch
from
582d351
to
3d3a2ee
Compare
|
@mdshuai Thanks for your comments. This is updated. Yes, I think node-config.yaml parameters will need to be expanded in a separate PR, although I pulled some relevant parameters into that section with these edits. |
|
[rev_history] |
https://bugzilla.redhat.com/show_bug.cgi?id=1354522