-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SRVKS-619] Add TLS cert docs for SM + Serverless #27660
Conversation
The preview will be available shortly at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes, looks good, but I could verify SSL connection. Prerequisites docs passed okay.
@abrennan89 @cardil This TLS doc also needs to update for SM 2.x. But we probably should work on https://issues.redhat.com/browse/SRVKS-655 first? Otherwise, only new TLS supports SM 2.x but other doc is still SM 1.x... |
6338424
to
a747549
Compare
60b408b
to
ff4a626
Compare
@cardil I made some updates to try to call out which versions someone should use in the scenarios you have outlined. Let me know if you think this is clear enough, otherwise we can add a comment re not supporting intermediate states as per your later comment, as a last resort. This isn't an ideal situation, but I think if we can provide additional guidance here for users, let's just take the hit and give them the best user experience we can until we have clearer stories around SM. Myself and Max will be meeting with the SM CS and DPM sometime in the coming weeks to try to figure out any shared issues we have, and how we can improve cross-product docs, so I'll raise these issues with migrations and compatibility then too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
from QE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things!
New changes are detected. LGTM label has been removed. |
LGTM, thanks for the update! Merging |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.6 |
@bergerhoffer: new pull request created: #28863 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #28864 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nak3 @cardil this PR is to finally add the content that was previously in the PR we closed due to not being able to verify this procedure.
Please review what is here and add suggestions if there's anything else we need to do or if you have any issues with verification.
If there are still steps required that can't be done without having documented steps for the underlying OpenShift part, we should discuss it with @sjstout as part of the core docs IMO, instead of trying to add it as a workaround in just this procedure.
Applies for OCP 4.6, 4.7