Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRVKS-619] Add TLS cert docs for SM + Serverless #27660

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

abrennan89
Copy link
Contributor

@nak3 @cardil this PR is to finally add the content that was previously in the PR we closed due to not being able to verify this procedure.

Please review what is here and add suggestions if there's anything else we need to do or if you have any issues with verification.

If there are still steps required that can't be done without having documented steps for the underlying OpenShift part, we should discuss it with @sjstout as part of the core docs IMO, instead of trying to add it as a workaround in just this procedure.

Applies for OCP 4.6, 4.7

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2020
@abrennan89 abrennan89 changed the title Add TLS cert docs for SM + Serverless [WIP] Add TLS cert docs for SM + Serverless Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2020
@abrennan89 abrennan89 changed the title [WIP] Add TLS cert docs for SM + Serverless [WIP] SRVKS-619: Add TLS cert docs for SM + Serverless Nov 25, 2020
@abrennan89 abrennan89 changed the title [WIP] SRVKS-619: Add TLS cert docs for SM + Serverless SRVKS-619: Add TLS cert docs for SM + Serverless Dec 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, looks good, but I could verify SSL connection. Prerequisites docs passed okay.

serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
@abrennan89
Copy link
Contributor Author

@cardil updates from your suggestions should be included now.
@nak3 can you please take a look at the issue Chris is having, since verifying this with QE is blocking the PR? Thanks!

@nak3
Copy link
Contributor

nak3 commented Jan 6, 2021

@abrennan89 @cardil This TLS doc also needs to update for SM 2.x. But we probably should work on https://issues.redhat.com/browse/SRVKS-655 first? Otherwise, only new TLS supports SM 2.x but other doc is still SM 1.x...

@abrennan89 abrennan89 changed the title SRVKS-619: Add TLS cert docs for SM + Serverless [WIP] [SRVKS-619] Add TLS cert docs for SM + Serverless Jan 6, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2021
@abrennan89
Copy link
Contributor Author

@nak3 @cardil I made some updates and split this into docs for v1 and v2, please confirm if these changes look OK to you.
Waiting for the generated preview so that I can review properly.

@abrennan89 abrennan89 changed the title [WIP] [SRVKS-619] Add TLS cert docs for SM + Serverless [SRVKS-619] Add TLS cert docs for SM + Serverless Jan 13, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2021
@abrennan89
Copy link
Contributor Author

@cardil I made some updates to try to call out which versions someone should use in the scenarios you have outlined. Let me know if you think this is clear enough, otherwise we can add a comment re not supporting intermediate states as per your later comment, as a last resort.

This isn't an ideal situation, but I think if we can provide additional guidance here for users, let's just take the hit and give them the best user experience we can until we have clearer stories around SM.

Myself and Max will be meeting with the SM CS and DPM sometime in the coming weeks to try to figure out any shared issues we have, and how we can improve cross-product docs, so I'll raise these issues with migrations and compatibility then too.

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from QE

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things!

serverless/networking/serverless-ossm-custom-domains.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
serverless/networking/serverless-ossm-tls.adoc Outdated Show resolved Hide resolved
modules/serverless-ossm-v1x-tls.adoc Show resolved Hide resolved
modules/serverless-ossm-v2x-tls.adoc Outdated Show resolved Hide resolved
modules/serverless-ossm-v2x-tls.adoc Outdated Show resolved Hide resolved
modules/serverless-ossm-v1x-tls.adoc Outdated Show resolved Hide resolved
modules/serverless-ossm-v1x-tls.adoc Outdated Show resolved Hide resolved
modules/serverless-ossm-v2x-tls.adoc Outdated Show resolved Hide resolved
@bergerhoffer bergerhoffer added branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Jan 25, 2021
@bergerhoffer bergerhoffer added this to the Next Release milestone Jan 25, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@bergerhoffer
Copy link
Contributor

LGTM, thanks for the update! Merging

@bergerhoffer bergerhoffer merged commit eeeca0b into openshift:master Jan 26, 2021
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jan 26, 2021

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jan 26, 2021

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 26, 2021

@bergerhoffer: new pull request created: #28863

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 26, 2021

@bergerhoffer: new pull request created: #28864

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants