Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShiftStack] 4.7 RNs #28504

Merged
merged 1 commit into from Feb 10, 2021
Merged

[ShiftStack] 4.7 RNs #28504

merged 1 commit into from Feb 10, 2021

Conversation

maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Jan 11, 2021 •
edited

4.7 release notes for OpenShift on OpenStack.

Feel extremely welcome to make PRs against maxwelldb:osp-on-ocp-rn-4.7.

@maxwelldb maxwelldb added this to the Future Release milestone Jan 11, 2021
@maxwelldb maxwelldb self-assigned this Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2021
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

mandre
mandre reviewed Jan 12, 2021
View reviewed changes
release_notes/ocp-4-7-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-7-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-7-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-7-release-notes.adoc Outdated Show resolved Hide resolved
dulek
dulek reviewed Jan 12, 2021
View reviewed changes
release_notes/ocp-4-7-release-notes.adoc Outdated
// Link when available. Custom subnets section.

[id="ocp-4-7-sr-iov"]
==== Support for SR-IOV machines on {rh-openstack}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth saying that this is not supported with Kuryr (probably works, but there are QE concerns). Also I believe only secondary SR-IOV interfaces are supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The docs for this are still in dev review, so I don't have a complete picture, here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This item is still up in the air. I'll confirm whether or not to conclude it immediately prior to publication.

@maxwelldb
Copy link
Contributor Author

TY so far!

Comments up to this point should be addressed in a72393f.

mandre
mandre reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Let's wait a bit more to give everyone at a chance to review.

@maxwelldb
Copy link
Contributor Author

Looks OK to me. Let's wait a bit more to give everyone at a chance to review.

Sure thing. This does not need quite as much lead time as the docs do. 👍

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2021
@maxwelldb maxwelldb force-pushed the osp-on-ocp-rn-4.7 branch 2 times, most recently from 59d74a3 to 4bcd7da Compare January 18, 2021 13:45
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2021
@maxwelldb
Copy link
Contributor Author

4.7 RN aggregation issue: #26801

@maxwelldb maxwelldb mentioned this pull request Jan 25, 2021
Merged
@maxwelldb maxwelldb removed the request for review from iamemilio February 3, 2021 20:11
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021 •
edited

Deploy preview for osdocs ready!

Built with commit 76eedb9

https://deploy-preview-28504--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2021
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Feb 10, 2021 •
edited

Direct preview link: https://deploy-preview-28504--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-7-release-notes.html

Latest build kicked off at 17:10 EST.

adellape
adellape approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 10, 2021
@maxwelldb maxwelldb merged commit 71990f5 into openshift:enterprise-4.7 Feb 10, 2021
@maxwelldb maxwelldb deleted the osp-on-ocp-rn-4.7 branch February 10, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek left review comments

@mandre mandre mandre left review comments

@luis5tb luis5tb luis5tb left review comments

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@adellape adellape adellape approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@adduarte adduarte Awaiting requested review from adduarte

Assignees

@maxwelldb maxwelldb

Labels
branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.7 GA
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@maxwelldb @openshift-docs-preview-bot @dulek @mandre @adellape @luis5tb @MaysaMacedo @adduarte @vikram-redhat @openshift-ci-robot