Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSMDOC-200 #28594

Merged
merged 1 commit into from
Feb 4, 2021
Merged

OSSMDOC-200 #28594

merged 1 commit into from
Feb 4, 2021

Conversation

neal-timpe
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2021
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2021
@neal-timpe neal-timpe mentioned this pull request Jan 19, 2021
Merged
dgn
dgn reviewed Jan 20, 2021
View reviewed changes
Copy link

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a few minor comments

modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Jan 27, 2021 •
edited

Deploy preview for osdocs ready!

Built with commit 6435faf

https://deploy-preview-28594--osdocs.netlify.app

@neal-timpe
Copy link
Contributor Author

@dgn I've made some progress. Can you take another look? Thanks!

dgn
dgn approved these changes Feb 2, 2021
View reviewed changes
Copy link

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two minor things, otherwise lgtm!

modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
@neal-timpe
Copy link
Contributor Author

@yxun can you take a look at this PR? Thanks!

JStickler
JStickler suggested changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The headers need to focus more on user tasks than on the underlying features/technology.

modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
modules/ossm-security-auth-policy.adoc Outdated Show resolved Hide resolved
JStickler
JStickler reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good changes. But I still think having two procedures in a single module isn't Panthon2 compliant. We should ask Andrew when we meet with him Thursday.

modules/ossm-security-auth-policy.adoc Show resolved Hide resolved
@JStickler JStickler merged commit 7019d19 into openshift:master Feb 4, 2021
@JStickler
Copy link
Contributor

JStickler commented Feb 4, 2021 •
edited by openshift-ci-robot

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 4, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 4, 2021 •
edited by openshift-ci-robot

@JStickler: new pull request created: #29152

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

JStickler commented Feb 4, 2021 •
edited by openshift-ci-robot

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 4, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 4, 2021 •
edited by openshift-ci-robot

@JStickler: new pull request created: #29153

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossmdoc-200 branch March 11, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxun yxun yxun approved these changes

@dgn dgn dgn approved these changes

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@neal-timpe @openshift-docs-preview-bot @JStickler @openshift-cherrypick-robot @yxun @dgn @openshift-ci-robot