Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP3 updates #29513

Merged
merged 1 commit into from
Feb 17, 2021
Merged

TP3 updates #29513

merged 1 commit into from
Feb 17, 2021

Conversation

Preeticp
Copy link
Contributor

@Preeticp Preeticp commented Feb 16, 2021 •
edited

  • This PR covers all the changes for TP3:
    • Operator updates and support for restricted environment
    • Tutorial/Getting Started flow
  • Aligned team label: Dev Tools
  • This has been acked by SME/QE

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2021
@netlify
Copy link

netlify bot commented Feb 16, 2021 •
edited

Deploy preview for osdocs ready!

Built with commit 385c1ec

https://deploy-preview-29513--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2021
@Preeticp
Copy link
Contributor Author

@ppitonak @praveen4g0 PTAL at the PR and lmk if any further changes are needed. Here's the preview: https://deploy-preview-29513--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/creating-applications-with-cicd-pipelines.html
https://deploy-preview-29513--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/understanding-openshift-pipelines.html

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2021
@Preeticp
Copy link
Contributor Author

@nikhil-thomas can you please review these files in this PR: modules/op-pipelines-operator-in-restricted-environment.adoc
modules/op-installing-pipelines-operator-in-web-console.adoc
Here's the preview for the same: https://deploy-preview-29513--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/installing-pipelines.html

@savitaashture
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@Preeticp Preeticp changed the title [WIP] TP3 updates TP3 updates Feb 17, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2021
@ahardin-rh ahardin-rh added branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Feb 17, 2021
@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 17, 2021
@ahardin-rh
Copy link
Contributor

Just a few minor comments + please squash the multiple commits. Otherwise, looks great! Thanks!

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@Preeticp
TP3 updates
385c1ec 
YAML updates

operator in proxy envt

operator change

review edits

review edit 2

review edits
@Preeticp
Copy link
Contributor Author

Thank you @ahardin-rh all comments fixed and commits squashed. Please merge if it looks good.

jeana-redhat
jeana-redhat approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving exception

@jeana-redhat jeana-redhat merged commit 1fd3c7b into openshift:master Feb 17, 2021
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #29566

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@VeereshAradhya VeereshAradhya VeereshAradhya left review comments

@ahardin-rh ahardin-rh ahardin-rh left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

@khrm khrm Awaiting requested review from khrm

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@savitaashture savitaashture

Labels
branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.7 GA
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Preeticp @savitaashture @ahardin-rh @openshift-ci-robot @jeana-redhat @openshift-cherrypick-robot @khrm @VeereshAradhya @vikram-redhat