Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSMDOC-246: Deploying to production #30703

Merged
merged 1 commit into from
Jun 21, 2021
Merged

OSSMDOC-246: Deploying to production #30703

merged 1 commit into from
Jun 21, 2021

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Mar 19, 2021 •
edited

All reviews done ready to merge.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2021
@netlify
Copy link

netlify bot commented Mar 19, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d6fa60c

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d0923beff120000760c236

😎 Browse the preview: https://deploy-preview-30703--osdocs.netlify.app

@neal-timpe neal-timpe requested a review from rcernich April 6, 2021 17:17
rcernich
rcernich reviewed Apr 8, 2021
View reviewed changes
modules/ossm-smcp-prod.adoc Outdated Show resolved Hide resolved
modules/ossm-smcp-prod.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2021
rcernich
rcernich approved these changes Apr 19, 2021
View reviewed changes
Copy link

@rcernich rcernich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neal-timpe neal-timpe mentioned this pull request May 6, 2021
Merged
@neal-timpe neal-timpe changed the title OSSMDOC-246 OSSMDOC-246: Deploying to production Jun 2, 2021
@neal-timpe neal-timpe force-pushed the ossmdoc-246 branch 2 times, most recently from 776d61c to 0ad6fd3 Compare June 16, 2021 16:03
@neal-timpe neal-timpe requested a review from gbaufake June 16, 2021 21:26
@neal-timpe
Copy link
Contributor Author

@jc-berger Thanks for the review. I knocked those out except for the link. Thanks for taking the time to read it!

jc-berger
jc-berger approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from doc's point of view. Good work!

@jc-berger
Copy link
Contributor

@neal-timpe , great! go ahead and merge as far as docs is concerned!

@neal-timpe neal-timpe added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 18, 2021
@Preeticp
Copy link
Contributor

/lgtm

@Preeticp Preeticp merged commit 01ffe28 into openshift:master Jun 21, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.6

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #33687

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #33688

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #33689

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2021
Merged
@neal-timpe neal-timpe deleted the ossmdoc-246 branch June 21, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcernich rcernich rcernich approved these changes

@gbaufake gbaufake gbaufake approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees

@Preeticp Preeticp

Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@neal-timpe @jc-berger @Preeticp @openshift-cherrypick-robot @rcernich @gbaufake @openshift-ci-robot