Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified YAML sample for EventListener necessary to add triggers. #31050

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Modified YAML sample for EventListener necessary to add triggers. #31050

merged 1 commit into from
Apr 20, 2021

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Mar 29, 2021

Aligned team: Dev Tools
OCP version for cherry-picking: 4.7, 4.8
JIRA issue: RHDEVDOCS-2864
Preview pages: The YAML snippet in Step 7 of the section Adding Triggers to a Pipeline
SME/QE reviewer: Savita Ashture / Praveen Thangadancha

Relevant information - Corresponding PR for enterprise-4.6: #31051

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2021
@netlify
Copy link

netlify bot commented Mar 29, 2021

Deploy preview for osdocs ready!

Built with commit 7983d64

https://deploy-preview-31050--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2021
@praveen4g0
Copy link

/lgtm ❤️

@Preeticp Preeticp added branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Mar 31, 2021
@Preeticp Preeticp added this to the Next Release milestone Mar 31, 2021
@Preeticp Preeticp added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 31, 2021
Modified EventListener YAML based on QE feedback.

Corrected minor typo.

Rephrased a sentence to include more info.

Editorial changes based on Preeti's feedback

More editorial changes
@Preeticp
Copy link
Contributor

/lgtm

@Preeticp
Copy link
Contributor

Not to be merged till 1.4 GA

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@Preeticp Preeticp changed the title Modified YAML sample for EventListener necessary to add triggers. [WIP] Modified YAML sample for EventListener necessary to add triggers. Apr 1, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2021
@Preeticp Preeticp changed the title [WIP] Modified YAML sample for EventListener necessary to add triggers. Modified YAML sample for EventListener necessary to add triggers. Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@Preeticp Preeticp merged commit 1b96ef7 into openshift:master Apr 20, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@Preeticp: new pull request created: #31712

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #31713

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants