Bug 1886229 - Make multipath docs platform-agnostic #31140
Conversation
openshift-ci-robot
added
the
size/L
bobfuru
added
branch/enterprise-4.7
branch/enterprise-4.8
and removed
size/L
|
Deploy preview for osdocs ready! Built with commit fce597c |
openshift-ci-robot
added
the
size/L
bobfuru
force-pushed
the
BZ1942192
branch
2 times, most recently
from
b45bd64
to
5cc0497
Compare
|
@bobfuru The new filename is |
bobfuru
force-pushed
the
BZ1942192
branch
2 times, most recently
from
716cb09
to
6298b4e
Compare
|
Thank you for your comments, @SNiemann15 and @wvoesch - forgot to add the WIP label as I need to fix a few things still. I contemplated whether to leave the Z docs alone and let you all apply fixes separately but instead chose to go boldly where I probably shouldn't have! 😄 I'll def revert those changes in the day one install doc. And will tag you when things are more prepared for review. Thanks again! |
bobfuru
added
the
do-not-merge/work-in-progress
bobfuru
force-pushed
the
BZ1942192
branch
2 times, most recently
from
8c4774e
to
57f9046
Compare
bobfuru
removed
the
do-not-merge/work-in-progress
|
@jlebon @miabbott PTAL for SME review (@jlebon - once this is merged, we'll have the link for use in your #30697) |
|
@SNiemann15 and @wvoesch thank you for your comments. PTAL and let me know if you see anything missing from a Power/Z perspective. Thanks! |
bobfuru
force-pushed
the
BZ1942192
branch
5 times, most recently
from
5f1d3b2
to
4369469
Compare
|
I've applied @jlebon's feedback and the z/power changes are now only to fix trailing whitespaces, so I'm considering this approved from a SME perspective. @miabbott or @mike-nguyen Could one of you PTAL/approve for QE? Thanks! |
|
LGTM |
bobfuru
added
the
peer-review-needed
|
Looks great! |
ahardin-rh
added
peer-review-done
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
@bobfuru: new pull request created: #31890 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: new pull request created: #31891 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 1886229
Based on work in #30697, this PR makes updates to 4.7+ to emphasize that multipathing requires certain machine config parameters. In addition, this PR makes the content platform agnostic, removing the IBM Z/P ifdef. Also, it moves the machine config karg instructions to a new module in the Post-Installation Config book.
By removing the ifdef, the install docs for bm/vsphere now point out that additional steps are required for enabling multipath with FCP
Additionally, it removes backticks in a couple of headings per OCP doc guidelines.
PREVIEW LINK example of this in bare metal UPI doc here (see step 4): https://deploy-preview-31140--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/installing-bare-metal.html#installation-complete-user-infra_installing-bare-metal
PREVIEW LINK of new multipath module in post-install config docs here: https://deploy-preview-31140--osdocs.netlify.app/openshift-enterprise/latest/post_installation_configuration/machine-configuration-tasks.html#rhcos-enabling-multipath_post-install-machine-configuration-tasks