Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying Creating CI/CD Pipelines based on revised tutorial #31331

Merged
merged 1 commit into from Apr 20, 2021
Merged

Modifying Creating CI/CD Pipelines based on revised tutorial #31331

merged 1 commit into from Apr 20, 2021

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Apr 7, 2021 •
edited

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2021
@sounix000 sounix000 changed the title Modifying Creating CI/CD Pipelines based on revised tutorial [WIP] Modifying Creating CI/CD Pipelines based on revised tutorial Apr 7, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
@netlify
Copy link

netlify bot commented Apr 7, 2021 •
edited

Deploy preview for osdocs ready!

Built with commit a52d29b

https://deploy-preview-31331--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2021
@Preeticp Preeticp requested a review from ppitonak April 8, 2021 06:22
@Preeticp Preeticp added branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Apr 8, 2021
ppitonak
ppitonak suggested changes Apr 8, 2021
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename vote-api and vote-ui also in section Mirroring images to run pipelines in a restricted environment (both strings appear twice there)

cicd/pipelines/creating-applications-with-cicd-pipelines.adoc Outdated Show resolved Hide resolved
modules/op-creating-pipeline-tasks.adoc Outdated Show resolved Hide resolved
Preeticp
Preeticp reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@Preeticp Preeticp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, otherwise looks good. Thanks for fixing the cases of the CRD instances.

modules/op-creating-pipeline-tasks.adoc Outdated Show resolved Hide resolved
modules/op-creating-pipeline-tasks.adoc Outdated Show resolved Hide resolved
modules/op-creating-webhooks.adoc Outdated Show resolved Hide resolved
ppitonak
ppitonak suggested changes Apr 9, 2021
View reviewed changes
modules/op-running-a-pipeline.adoc Outdated Show resolved Hide resolved
modules/op-running-a-pipeline.adoc Outdated Show resolved Hide resolved
@ppitonak
Copy link

ppitonak commented Apr 13, 2021 •
edited

All PRs to Tutorial were merged, I tested YAML examples from this doc and everything works.

ppitonak
ppitonak approved these changes Apr 15, 2021
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 15, 2021
ppitonak
ppitonak approved these changes Apr 15, 2021
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@Preeticp Preeticp added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
Modifying Creating CI/CD Pipelines based on revised tutorial
a52d29b 
Additional link fixes

Additional URL fixes and editorial changes

Testing if links work with substitution in the preview builds.

Resolving comments from Pavol and Preeti

Updaing documentation based on https://github.com/openshift/pipelines-tutorial/pull/138/files

Testing if merge conflict is resolved by hard resetting head from the result of reflog

Additional corrections as per latest commits in dev+qe PR

Incorporating comments from Pavol and Veeresh

Trying to resolve merge conflict

Trying to resolve merge conflict

Restoring my changes after resolving merge conflicts.
@Preeticp Preeticp changed the title [WIP] Modifying Creating CI/CD Pipelines based on revised tutorial Modifying Creating CI/CD Pipelines based on revised tutorial Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@Preeticp
Copy link
Contributor

/lgtm

@Preeticp Preeticp merged commit d74bc83 into openshift:master Apr 20, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #31719

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #31720

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeereshAradhya VeereshAradhya VeereshAradhya left review comments

@Preeticp Preeticp Preeticp left review comments

@ppitonak ppitonak ppitonak approved these changes

Assignees

@ppitonak ppitonak

@Preeticp Preeticp

Labels
branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sounix000 @ppitonak @Preeticp @openshift-cherrypick-robot @VeereshAradhya @openshift-ci-robot