New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only global pull secrets can be configured in clusters where ImageContentSourcePolicy is set #31968
Conversation
Deploy preview for osdocs ready! Built with commit 5581340 |
@umohnani8 PTAL |
@sunilcio Is this an issue that you can review for QE? Thank you!! |
@mburke5678 LGTM, thanks! |
006f834
to
093a0af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Made a couple of small suggestions.
Build succeeds locally and previews look copacetic.
modules/builds-image-source.adoc
Outdated
+ | ||
[NOTE] | ||
==== | ||
In a cluster with an `ImageContentSourcePolicy` object, only global pull secrets can be configured for mirrored registries. You cannot add a pull secret to a project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a cluster with an `ImageContentSourcePolicy` object, only global pull secrets can be configured for mirrored registries. You cannot add a pull secret to a project. | |
You can only configure global pull secrets for clusters that have an `ImageContentSourcePolicy` object. You cannot add a pull secret to a project. |
Tried to make it a bit more active, as well as observe the ISG rule on "that" and restrictive clauses.
Same for all other notes.
@@ -30,10 +30,16 @@ By pulling container images needed by {product-title} and then bringing those im | |||
Even if you don't configure mirroring during {product-title} installation, you can do so later using the `ImageContentSourcePolicy` object. | |||
|
|||
The following procedure provides a post-installation mirror configuration, where you create an `ImageContentSourcePolicy` object that identifies: | |||
|
|||
-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unusual to see open blocks used with lists in our docs. Seems to render fine, though.
…tentSourcePolicy is set Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
/cherrypick enterprise-4.6 |
@mburke5678: new pull request created: #32237 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.8 |
@mburke5678: new pull request created: #32238 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mburke5678: new pull request created: #32239 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1889413
Added the same note in multiple locations.
Previews:
Configuring image registry repository mirroring. The new link is at the bottom of this file.
Mirroring an Operator catalog
Mirroring a Package Manifest Format catalog image
Mirroring the OpenShift Container Platform image repository
Upgrading the restricted network cluster
Image source