Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only global pull secrets can be configured in clusters where ImageContentSourcePolicy is set #31968

Merged
merged 1 commit into from May 5, 2021

Conversation

@netlify
Copy link

netlify bot commented Apr 27, 2021

Deploy preview for osdocs ready!

Built with commit 5581340

https://deploy-preview-31968--osdocs.netlify.app

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2021
@mburke5678
Copy link
Contributor Author

@umohnani8 PTAL

@mburke5678
Copy link
Contributor Author

@sunilcio Is this an issue that you can review for QE? Thank you!!

@sunilcio
Copy link

sunilcio commented May 5, 2021

@mburke5678 LGTM, thanks!

@mburke5678 mburke5678 added this to the Next Release milestone May 5, 2021
@mburke5678 mburke5678 force-pushed the BZ-1889413 branch 2 times, most recently from 006f834 to 093a0af Compare May 5, 2021 12:56
@maxwelldb maxwelldb self-requested a review May 5, 2021 13:29
@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label May 5, 2021
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Made a couple of small suggestions.

Build succeeds locally and previews look copacetic.

+
[NOTE]
====
In a cluster with an `ImageContentSourcePolicy` object, only global pull secrets can be configured for mirrored registries. You cannot add a pull secret to a project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In a cluster with an `ImageContentSourcePolicy` object, only global pull secrets can be configured for mirrored registries. You cannot add a pull secret to a project.
You can only configure global pull secrets for clusters that have an `ImageContentSourcePolicy` object. You cannot add a pull secret to a project.

Tried to make it a bit more active, as well as observe the ISG rule on "that" and restrictive clauses.

Same for all other notes.

openshift_images/image-configuration.adoc Outdated Show resolved Hide resolved
@@ -30,10 +30,16 @@ By pulling container images needed by {product-title} and then bringing those im
Even if you don't configure mirroring during {product-title} installation, you can do so later using the `ImageContentSourcePolicy` object.

The following procedure provides a post-installation mirror configuration, where you create an `ImageContentSourcePolicy` object that identifies:

--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unusual to see open blocks used with lists in our docs. Seems to render fine, though.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 5, 2021
…tentSourcePolicy is set

Co-authored-by: Max Bridges <50179998+maxwelldb@users.noreply.github.com>
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mburke5678: new pull request created: #32237

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.7

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #32238

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #32239

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants