Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-329: Performance scalability review #32981

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Jun 1, 2021

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2021
@netlify
Copy link

netlify bot commented Jun 1, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d4c42e6

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dcbf4b7b869b0008e33d88

😎 Browse the preview: https://deploy-preview-32981--osdocs.netlify.app

@gbaufake
Copy link

@neal-timpe can you assign me as a reviewer on this one?

@neal-timpe
Copy link
Contributor Author

@gbaufake This one is still in progress. I've just started on it also. I don't think it's ready for an approval type review yet.

But if you have feedback on this topic, it would be great if you could leave it here. I'll add you as a reviewer when I have more content.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2021
@neal-timpe neal-timpe changed the title OSSMDOC-329: performance scalability reorg OSSMDOC-329: Performance scalability review Jun 21, 2021
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
@neal-timpe neal-timpe requested a review from gbaufake June 24, 2021 15:06
@mburke5678
Copy link
Contributor

A couple of nits (some for existing text) and one thought about a possible larger future change.

@mburke5678 mburke5678 added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 30, 2021
@neal-timpe
Copy link
Contributor Author

@mburke5678 I just knocked out your review comments. I'm ready for merge if you're the merger. 4.6-4.8 please?

@mburke5678 mburke5678 merged commit 25c181c into openshift:master Jun 30, 2021
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mburke5678: new pull request created: #34186

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.7

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #34187

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #34188

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossmdoc-329 branch July 8, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants