-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSMDOC-329: Performance scalability review #32981
Conversation
neal-timpe
commented
Jun 1, 2021
•
edited
edited
- Aligned team: Service mesh
- For branches: 4.6, 4.7, 4.8
- Moved a procedure module about how to update adjust the scalability.
- Style updates
- https://issues.redhat.com/browse/OSSMDOC-329
- https://deploy-preview-32981--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-performance-scalability
- SME review: knrc
- QE review: yxun
- Peer review: mburke5678
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: d4c42e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dcbf4b7b869b0008e33d88 😎 Browse the preview: https://deploy-preview-32981--osdocs.netlify.app |
@neal-timpe can you assign me as a reviewer on this one? |
@gbaufake This one is still in progress. I've just started on it also. I don't think it's ready for an approval type review yet. But if you have feedback on this topic, it would be great if you could leave it here. I'll add you as a reviewer when I have more content. |
A couple of nits (some for existing text) and one thought about a possible larger future change. |
@mburke5678 I just knocked out your review comments. I'm ready for merge if you're the merger. 4.6-4.8 please? |
/cherrypick enterprise-4.6 |
@mburke5678: new pull request created: #34186 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.8 |
@mburke5678: new pull request created: #34187 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mburke5678: new pull request created: #34188 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |