Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-327: Architecture review #33782

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Jun 22, 2021

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 195286c

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d24a590829550008b14eca

😎 Browse the preview: https://deploy-preview-33782--osdocs.netlify.app

Copy link
Contributor

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, data plural and datum singular makes it into tech docs.

Looks good.

@mikemckiernan mikemckiernan merged commit b193808 into openshift:master Jun 25, 2021
@mikemckiernan
Copy link
Contributor

/cherrypick enterprise-4.8

@mikemckiernan mikemckiernan added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 25, 2021
@mikemckiernan mikemckiernan added this to the Next Release milestone Jun 25, 2021
@openshift-cherrypick-robot

@mikemckiernan: new pull request created: #33971

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikemckiernan
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@mikemckiernan: new pull request created: #33972

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikemckiernan
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@mikemckiernan: new pull request created: #33973

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossmdoc-327 branch July 8, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants