Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-2886: Docs for using custom pipeline template in Git import workflows #33967

Merged
merged 1 commit into from
Jun 25, 2021
Merged

RHDEVDOCS-2886: Docs for using custom pipeline template in Git import workflows #33967

merged 1 commit into from
Jun 25, 2021

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Jun 25, 2021 •
edited

NOTE: The merge in OCP-4.7 has been reverted - #34043

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2021
@netlify
Copy link

netlify bot commented Jun 25, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 19d305d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d6137fa9df5c0007cd2d4c

😎 Browse the preview: https://deploy-preview-33967--osdocs.netlify.app

ppitonak
ppitonak approved these changes Jun 25, 2021
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
pradeepitm12
pradeepitm12 reviewed Jun 25, 2021
View reviewed changes
Copy link

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Preeticp
Preeticp reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@Preeticp Preeticp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, have left some minor suggestions, PTAL.

modules/op-using-custom-pipeline-template-for-git-import.adoc Outdated Show resolved Hide resolved
modules/op-using-custom-pipeline-template-for-git-import.adoc Outdated Show resolved Hide resolved
modules/op-using-custom-pipeline-template-for-git-import.adoc Outdated Show resolved Hide resolved
modules/op-using-custom-pipeline-template-for-git-import.adoc Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@Preeticp Preeticp added branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Jun 25, 2021
@Preeticp Preeticp changed the title Docs for using custom pipeline template in Git import workflows RHDEVDOCS-2886: Docs for using custom pipeline template in Git import workflows Jun 25, 2021
@Preeticp Preeticp added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 25, 2021
Docs for using custom pipeline template in Git import workflows
19d305d 
Structural improvements and additional information

commented out includes

Incorporated Preeti's comments

Small grammatical correction

Revision
@Preeticp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@Preeticp Preeticp merged commit 47711b7 into openshift:master Jun 25, 2021
@Preeticp
Copy link
Contributor

/cherypick enterprise-4.8

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 25, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #33991

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 25, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #33992

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sounix000
Copy link
Contributor Author

NOTE: The merge in OCP-4.7 has been reverted - #34043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Preeticp Preeticp Preeticp left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@ppitonak ppitonak ppitonak approved these changes

Assignees

@ppitonak ppitonak

@Preeticp Preeticp

@pradeepitm12 pradeepitm12

Labels
branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sounix000 @Preeticp @openshift-cherrypick-robot @ppitonak @pradeepitm12