Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIG-753: Generic S3 storage #34146

Merged
merged 1 commit into from
Jul 13, 2021
Merged

MIG-753: Generic S3 storage #34146

merged 1 commit into from
Jul 13, 2021

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jun 30, 2021 •
edited

@apinnick apinnick added this to the Next Release milestone Jun 30, 2021
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2021
@netlify
Copy link

netlify bot commented Jun 30, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 1cbf908

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ed558290e929000701c76e

😎 Browse the preview: https://deploy-preview-34146--osdocs.netlify.app

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2021
@xinredhat
Copy link

LGTM

@apinnick apinnick added peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR and removed QE Required labels Jul 1, 2021
@apinnick apinnick force-pushed the mig753-generic-storage branch 3 times, most recently from c7f8e50 to 4b16b86 Compare July 4, 2021 09:18
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2021
@apinnick apinnick force-pushed the mig753-generic-storage branch 2 times, most recently from 9fef61d to 6c953b7 Compare July 4, 2021 10:12
skrthomas
skrthomas reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, otherwise LGTM!

modules/migration-adding-replication-repository-to-cam.adoc Show resolved Hide resolved
migration-toolkit-for-containers/installing-mtc.adoc Outdated Show resolved Hide resolved
@apinnick apinnick added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 8, 2021
@apinnick apinnick merged commit 4daac49 into openshift:master Jul 13, 2021
@apinnick apinnick deleted the mig753-generic-storage branch July 13, 2021 09:01
@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.5

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.6

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.7

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2021
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #34492

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #34493

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 13, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #34494

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #34495

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinredhat xinredhat xinredhat left review comments

@skrthomas skrthomas skrthomas left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@apinnick @xinredhat @openshift-cherrypick-robot @skrthomas