Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ1974689: CNV VM import UI error message #34375

Merged
merged 1 commit into from Jul 13, 2021
Merged

BZ1974689: CNV VM import UI error message #34375

merged 1 commit into from Jul 13, 2021

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jul 7, 2021 •
edited

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2021
@apinnick apinnick added this to the Next Release milestone Jul 7, 2021
@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: ac793e4

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ec282782ef7a000741d236

😎 Browse the preview: https://deploy-preview-34375--osdocs.netlify.app/openshift-enterprise/latest/virt/virt-4-8-release-notes

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2021
@apinnick apinnick removed CNV Label for all CNV PRs QE Required branch/enterprise-4.8 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2021
@apinnick apinnick closed this Jul 12, 2021
@apinnick apinnick reopened this Jul 12, 2021
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2021
@apinnick apinnick force-pushed the bz1979885-cnv-vm-warning-rn branch from 8070c9c to ac793e4 Compare July 12, 2021 11:31
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2021
sjhala-ccs
sjhala-ccs reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhala-ccs sjhala-ccs added branch/enterprise-4.8 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 12, 2021
@apinnick
Copy link
Contributor Author

LGTM

@sjhala-ccs Can you merge this? I heard you have merge rights.

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs Can you merge this? I heard you have merge rights.

Sorry, only @ousleyp has merge rights during repo freeze.

@apinnick apinnick merged commit 0c43310 into openshift:enterprise-4.8 Jul 13, 2021
@apinnick apinnick deleted the bz1979885-cnv-vm-warning-rn branch July 13, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.8 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apinnick @sjhala-ccs