BZ1980340: [DOC-OCPRHV] Add resize to ovirt CSI driver #34475
Conversation
openshift-ci
bot
added
the
size/S
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 6e90398 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/610ba8f5edde5a0008b2ed5d 😎 Browse the preview: https://deploy-preview-34475--osdocs.netlify.app |
openshift-ci
bot
added
size/M
|
@Gal-Zaidman Please review. |
|
@Gal-Zaidman Is the rest of the topic OK as-is? |
stoobie
force-pushed
the
1980340
branch
2 times, most recently
from
f56f6b5
to
3bba269
Compare
|
Things look OK to me I think you fixed all my comments |
vikram-redhat
changed the title
vikram-redhat
changed the title
|
@Gal-Zaidman : @mgold1234 thinks it would be helpful to add explanations of these two items:
What do you think? |
stoobie
force-pushed
the
1980340
branch
5 times, most recently
from
972d0f0
to
83dbe6e
Compare
There was a problem hiding this comment.
A couple of minor requests and otherwise this LGTM! Also, not a part of this PR but I noticed a typo in the module "Creating a persistent volume on RHV" (persistent-storage-rhv.adoc), the first line of the procedure: "If you are using the we console...." Would you mind fixing this as well? 🙇
|
|
||
| {product-title} creates a default object of type `StorageClass` named `ovirt-csi-sc` which is used for creating dynamically provisioned persistent volumes. | ||
|
|
||
| To create additional storage classes for different configurations, create and save a file with the `StorageClass` object described by the following sample YAML: | ||
|
|
||
| .ovirt-storageclass.yaml | ||
| [source,yaml] | ||
| ---- | ||
| apiVersion: storage.k8s.io/v1 | ||
| kind: StorageClass | ||
| metadata: | ||
| name: <storage-class-name> <1> |
There was a problem hiding this comment.
Could you please make this storage_class_name (use underscores) to be in line with our convention? Thanks!
There was a problem hiding this comment.
Fixed. Thanks for pointing this out.
| <5> Indicates how to provision and bind `PersistentVolumeClaims`. When not set, `VolumeBindingImmediate` is used. This field is only applied by servers that enable the `VolumeScheduling` feature. | ||
| <6> The {rh-virtualization} storage domain name to use. | ||
| <7> If `true`, the disk is thin provisioned. If `false`, the disk is preallocated. Thin provisioning is recommended. | ||
| <8> (Optional) File system type to be created. Possible values: `ext4` (default) or `xfs`. |
There was a problem hiding this comment.
s/(Optional) File/Optional: File
This is how we generally introduce an optional step or value (with a colon).
There was a problem hiding this comment.
Fixed. The IBM SG actually says the same thing you did.
However, I found a lot of other instances of this in files that I don't own. I went ahead and made a few changes there too, even though those files are not connected to this PR. I can undo the changes if you like.
There are an additional 37 occurrences of (optional) in 19 files.
There was a problem hiding this comment.
That's fantastic, thanks for taking care of all these.
bobfuru
added
the
peer-review-done
|
@bobfuru I made the changes you suggested. Please approve and set this in the merge queue, or let me know what else should change. |
Implemented SME comments. Implemented QE commens. Implemented Peer review comments.
|
LGTM - will merge/CP to 4.9 |
|
/cherrypick enterprise-4.9 |
|
@bobfuru: new pull request created: #35255 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
enterprise_4.9
For versions 4.9+
https://bugzilla.redhat.com/show_bug.cgi?id=1980340
Direct link to doc preview:
deploy-preview-34475--osdocs.netlify.app/?utm_source=github&utm_campaign=bot_dp
For each item in bug comment 2:
https://deploy-preview-34475--osdocs.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi.html#csi-drivers-supported_persistent-storage-csi
and 4. oVirt CSI driver storage class (code example):
https://deploy-preview-34475--osdocs.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-ovirt.html#ovirt-csi-driver-storage-class_persistent-storage-csi-ovirt
Creating a persistent volume on RHV > pvc-ovirt.yaml:
https://deploy-preview-34475--osdocs.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-ovirt.html#persistent-storage-rhv_persistent-storage-csi-ovirt
Add a section for RHV/oVirt just as there are specifics for other providers. Use code example from previous item.
https://deploy-preview-34475--osdocs.netlify.app/openshift-enterprise/latest/post_installation_configuration/storage-configuration.html#ovirt-csi-driver-storage-class_post-install-storage-configuration