Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHDEVDOCS-2386]: Jenkins to Tekton Migration Guide #34792

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[RHDEVDOCS-2386]: Jenkins to Tekton Migration Guide #34792

merged 1 commit into from
Jul 28, 2021

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Jul 21, 2021 •
edited

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e404bf2

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/610193e592711f000843fc4c

😎 Browse the preview: https://deploy-preview-34792--osdocs.netlify.app

@Preeticp Preeticp changed the title Jenkins to Tekton Migration Guide [WIP][RHDEVDOCS-2386]:Jenkins to Tekton Migration Guide Jul 22, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2021
ppitonak
ppitonak suggested changes Jul 22, 2021
View reviewed changes
modules/jenkins-to-tekton-migration-guide.adoc Outdated Show resolved Hide resolved
modules/jenkins-to-tekton-migration-guide.adoc Outdated Show resolved Hide resolved
modules/jenkins-to-tekton-migration-guide.adoc Outdated Show resolved Hide resolved
modules/jenkins-to-tekton-migration-guide.adoc Outdated Show resolved Hide resolved
vdemeester
vdemeester approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@sounix000 sounix000 changed the title [WIP][RHDEVDOCS-2386]:Jenkins to Tekton Migration Guide [RHDEVDOCS-2386]: Jenkins to Tekton Migration Guide Jul 28, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
jc-berger
jc-berger approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I left optional suggestion for rephrasing. Almost all of which can be saved for a later PR and iteration if this PR needs to get merged ASAP.

Great work!

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

I left optional suggestion for rephrasing. Almost all of which can be saved for a later PR and iteration if this PR needs to get merged ASAP.

Great work!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
Srivaralakshmi
Srivaralakshmi reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 Amazing work! Left some comments and suggestions. PTAL. Thanks!

modules/jt-comparing-jenkins-tekton-concepts.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-concepts.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-concepts.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-concepts.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-concepts.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-execution-models.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-execution-models.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-execution-models.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-execution-models.adoc Outdated Show resolved Hide resolved
modules/jt-comparing-jenkins-tekton-execution-models.adoc Outdated Show resolved Hide resolved
jc-berger
jc-berger approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jenkins to Tekton Migration Guide
e404bf2 
Jenkins to Tekton migration guide content

Resolved Pavol's comments

Refactoring into modules

Fixed file-not-found error

fixed errors pointed out by Preeti

Fixed wrong file name

Fixed typos

Peer review comments from Jake

Incorporated Sri's comments
@Preeticp Preeticp added branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Jul 28, 2021
@Preeticp Preeticp merged commit df67bfb into openshift:main Jul 28, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34956

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34957

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@ppitonak ppitonak ppitonak requested changes

@vdemeester vdemeester vdemeester approved these changes

@rupalibehera rupalibehera rupalibehera approved these changes

@jc-berger jc-berger jc-berger approved these changes

Assignees

@vdemeester vdemeester

Labels
branch/enterprise-4.8 branch/enterprise-4.9 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sounix000 @Preeticp @openshift-cherrypick-robot @vdemeester @ppitonak @rupalibehera @jc-berger @Srivaralakshmi