Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-313: Document OSSM ability to copy annotations #34854

Merged
merged 1 commit into from Jul 27, 2021

Conversation

jwendell
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2021
@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 3247d80

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61000c2c1adc500007281652

😎 Browse the preview: https://deploy-preview-34854--osdocs.netlify.app


Sometimes specific annotations are needed in an OpenShift Route. For example, some advanced features in OpenShift Routes are managed via xref:../../networking/routes/route-configuration.adoc[special annotations]. For this and other use cases, {ProductName} will copy all annotations present in the Istio Gateway resource (with the exception of those starting with `kubectl.kubernetes.io`) into the managed OpenShift Route resource.

Thus, if you need specific annotations to be present in the OpenShift Routes created by {ProductName}, just add them to the Istio Gateway resource and they will be copied over.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for rewording, "If you need specific annotations in the OpenShift Routes created by {ProductName}, create then in the Istio Gateway resource and {ProductName} will copy them into the OpenShift Route resources managed by the {ProductName} Operator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JStickler JStickler self-requested a review July 26, 2021 19:42
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit 746ca4a into openshift:main Jul 27, 2021
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.7

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@JStickler: new pull request created: #34892

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #34893

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #34894

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.9

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@JStickler: new pull request created: #40476

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #40477

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants