Make gluster endpoints and service the same name #3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the endpoints from being automatically deleted
|
LGTM. Thanks! |
|
May I ask you to modify the notes in the line:
and
to like "This name must match the {service,endpoints}". This section has the notes and it was really helpful. |
|
Thanks! @nak3 I will follow up with that edit, as well as some other edits, in a separate PR while I continue to address https://bugzilla.redhat.com/show_bug.cgi?id=1408293 |
This was referenced Feb 1, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the endpoints from being automatically deleted