Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node release notes for 4.9 #36001

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Node release notes for 4.9 #36001

merged 1 commit into from
Sep 30, 2021

Conversation

mburke5678
Copy link
Contributor

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2021
@netlify
Copy link

netlify bot commented Sep 1, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9bf018e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6154d8bc7c3c0f0009e98a3f

😎 Browse the preview: https://deploy-preview-36001--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes

@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 1, 2021 •
edited

@gauravsingh85 @rphillips @saschagrunert PTAL

Are there any other Node Jiras (including Alongside-4.9) that should be added to the release notes?

saschagrunert
saschagrunert approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift openshift deleted a comment from gaurav-nelson Sep 2, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@mburke5678
Copy link
Contributor Author

@sunilcio PTAL

1 similar comment
@mburke5678
Copy link
Contributor Author

@sunilcio PTAL

@sunilcio
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2021
@mburke5678 mburke5678 force-pushed the release-notes-4.9-node branch 2 times, most recently from 9f4ac73 to da85721 Compare September 29, 2021 19:51
jeana-redhat
jeana-redhat approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The absolute most minor nit/food for thought - LGTM

release_notes/ocp-4-9-release-notes.adoc Outdated
[id="ocp-4-9-nodes-enhanced-monitoring"]
==== Enhanced monitoring of node resources

Node-related metrics and alerts have been enhanced to give you an earlier indication of when the stability of a node is compromised, by reducing the time between the notification and the node failure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first thought on reading "reducing the time between the notification and the node failure" was that it sounds like the opposite of what I'd want, because i was thinking the alert would happen first and then the failure (so more lead time would be better). But I'm thinking this alert is after the failure, right? I wonder if it would make sense to flip the order of these two things in the sentence so the temporal relationship is really obvious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I will look in the Jiras again to confirm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeana-redhat I am going to remove that phrase. I think it's largely redundant. I got that wording from the description in the dev Jira.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes - good point, it's totally fine without it at all :)

@jeana-redhat jeana-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 29, 2021
@jeana-redhat jeana-redhat added this to the Future Release milestone Sep 29, 2021
@mburke5678 mburke5678 merged commit bbaa82f into openshift:enterprise-4.9 Sep 30, 2021
@mburke5678 mburke5678 deleted the release-notes-4.9-node branch September 30, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@sunilcio sunilcio

Labels
branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.9 GA
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mburke5678 @sunilcio @saschagrunert @jeana-redhat @vikram-redhat