Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-2796: Access-PipelineRun-TaskRun-Logs-in-OpenShift-Cluster-Logging #36023

Merged
merged 1 commit into from
Sep 27, 2021
Merged

RHDEVDOCS-2796: Access-PipelineRun-TaskRun-Logs-in-OpenShift-Cluster-Logging #36023

merged 1 commit into from
Sep 27, 2021

Conversation

sounix000
Copy link
Contributor

@sounix000 sounix000 commented Sep 2, 2021 •
edited

Note: Separate PR for cherrrypicking for enterprise-4.7 to be created.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2021
@netlify
Copy link

netlify bot commented Sep 2, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4e26503

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6151c648bc84de00071a849f

😎 Browse the preview: https://deploy-preview-36023--osdocs.netlify.app

@sounix000 sounix000 mentioned this pull request Sep 3, 2021
Closed
rkratky
rkratky suggested changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@rkratky rkratky left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks and a syntax fix added.

cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
@khrm
Copy link

khrm commented Sep 6, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2021
@sounix000 sounix000 changed the title [WIP] RHDEVDOCS-2796: Access-PipelineRun-TaskRun-Logs-in-OpenShift-Cluster-Logging RHDEVDOCS-2796: Access-PipelineRun-TaskRun-Logs-in-OpenShift-Cluster-Logging Sep 6, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2021
sagidlow
sagidlow reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@sagidlow sagidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just left some comments for you to address and consider.

cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Outdated Show resolved Hide resolved
modules/op-viewing-pipeline-logs-in-kibana.adoc Show resolved Hide resolved
@sagidlow sagidlow added this to the Next Release milestone Sep 7, 2021
abrennan89
abrennan89 requested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments / suggestions

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
abrennan89
abrennan89 requested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments

cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Outdated Show resolved Hide resolved
cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator.adoc Show resolved Hide resolved
abrennan89
abrennan89 requested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: scratch that below comment, it renders fine now

One small issue with rendering also

@sounix000
Copy link
Contributor Author

@abrennan89 All suggestions incorporated, PTAL.

abrennan89
abrennan89 requested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.
There seems to be a heading rendering oddly at the bottom of the page for additional resources but that might be due to the formatting.
https://deploy-preview-36023--osdocs.netlify.app/openshift-enterprise/latest/cicd/pipelines/viewing-pipeline-logs-using-the-openshift-logging-operator#op-viewing-pipeline-logs-in-kibana_viewing-pipeline-logs-using-the-openshift-logging-operator

Also, the TOC is missing from this page. Please review https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#assembly-file-metadata and ensure that you are following all the guidelines for assemblies.

@sounix000
Copy link
Contributor Author

@abrennan89 - Incorporated yesterday's suggestions. PTAL.

@sounix000
Copy link
Contributor Author

@abrennan89 - Everything is rendering correctly now. Thanks for the guidance.

abrennan89
abrennan89 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
Fresh PR
4e26503 
Modified common-attributes to see if build error get resolved

minor editorial fixes

Minor editorial changes

Trying to solve build errors

Adding text before xref in Additional Resources

Minor edits

Incorporated Robert's comments

Incorporated peer review comments

Incorporated peer review editorial suggestions

Incorporated peer review suggestions

EDits to resolve rendering issue
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2021
@Preeticp Preeticp added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2021
@Preeticp Preeticp merged commit e3b44cb into openshift:main Sep 27, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link

@Preeticp: #36023 failed to apply on top of branch "enterprise-4.7":

Applying: Fresh PR
.git/rebase-apply/patch:3897: space before tab in indent.
  	"kubernetes.flat_labels": {
.git/rebase-apply/patch:3898: space before tab in indent.
    	"query": "app_kubernetes_io/managed-by=tekton-pipelines",
.git/rebase-apply/patch:3899: space before tab in indent.
    	"type": "phrase"
.git/rebase-apply/patch:3900: space before tab in indent.
  	}
.git/rebase-apply/patch:3919: space before tab in indent.
  	"kubernetes.flat_labels": {
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_map.yml
Falling back to patching base and 3-way merge...
Auto-merging _topic_map.yml
CONFLICT (content): Merge conflict in _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fresh PR
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 27, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #36792

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 27, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #36793

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer mentioned this pull request Oct 4, 2021
Merged
@sounix000 sounix000 mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagidlow sagidlow sagidlow left review comments

@rkratky rkratky rkratky requested changes

@abrennan89 abrennan89 abrennan89 approved these changes

Assignees

@khrm khrm

@abrennan89 abrennan89

Labels
branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sounix000 @khrm @Preeticp @openshift-cherrypick-robot @rkratky @abrennan89 @sagidlow